build: Added WhitespaceAround and WhitespaceAfter rules to Checkstyle config #625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Actually I was wrong with adding the OperatorWrap check as solution to test for leading/trailing spaces around operators.
OperatorWrap only ensures that we get the following pattern when line wraps are needed: The proper solution here is to use
WhitespaceAround
andWhitespaceAfter
.Checkstyle will complain this one using OperatorWrap:
It will permit:
To check if e.g. spaces are placed around operators or lambdas or behind a comma, following 2 rules apply.
Please test so we can find a suitable configuration.
This setup ensures that we actually get the whitespaces around lambdas, around operators
+
,||
, etc and it ensures that e.g. missing whitespace after,
or{
is detected.WhitespaceAround: https://checkstyle.org/config_whitespace.html#WhitespaceAround
WhitespaceAfter: https://checkstyle.org/config_whitespace.html#WhitespaceAfter
Fixes #620
Progress