Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add library manager documentation #714

Merged
merged 9 commits into from
Sep 25, 2024

Conversation

jperedadnr
Copy link
Collaborator

@jperedadnr jperedadnr commented Sep 23, 2024

Issue

Fixes #713

Progress

Copy link
Collaborator

@Oliver-Loeffler Oliver-Loeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks as a great starting point to me. Also we can add more docs here at this space. On which OS did you create the screenshots?

@jperedadnr
Copy link
Collaborator Author

The idea is to have docs for every other documentation that we want to include, of course. For now, this is a first contribution, for the Library Manager feature, that is not included elsewhere (except from the Gluon docs).

I'm on macOS.

@Oliver-Loeffler
Copy link
Collaborator

@jperedadnr Do you have any chance to preview the MD on Linux or Windows? The images created on macOS usually appear twice as large as needed due to hidpi rendering on macOS. However, for all images which only show a small portion of the screen, scaling can be set to 50%. Not sure how this is handled between macOS / Windows and Linux. On Windows the images appear too large. Is there any chance to assign dpis to an image tag?

@jperedadnr
Copy link
Collaborator Author

I was trying to limit the size via css, but I noticed that doesn't work with GitHub md files, so I've finally added the old width="400" to the img tag. Did you check after my latest commit?

@Oliver-Loeffler
Copy link
Collaborator

This seems now to work quite fine. 400px seems reasonable for the most elements. For images like SceneBuilder01.png I would go with 800px or 600px, everything else 400px is okay. However, this is my subjective impression. Technically this is fine.

Copy link
Collaborator

@Oliver-Loeffler Oliver-Loeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks now quite nice.

@Oliver-Loeffler Oliver-Loeffler merged commit ddf0ba2 into gluonhq:master Sep 25, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document use of library manager and custom controls
3 participants