Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Restore back removed metadata for DialogPane #763

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

jperedadnr
Copy link
Collaborator

Issue

Fixes #762

Progress

@jperedadnr jperedadnr changed the title Restore back removed metadata for DialogPane fix: Restore back removed metadata for DialogPane Oct 21, 2024
@jperedadnr jperedadnr closed this Oct 22, 2024
@jperedadnr jperedadnr deleted the 762-metadata branch October 22, 2024 12:59
@jperedadnr jperedadnr restored the 762-metadata branch October 22, 2024 13:17
@jperedadnr jperedadnr reopened this Oct 22, 2024
@abhinayagarwal
Copy link
Collaborator

The current implementation places a AnchorPane in both HEADER and CONTENT nodes. Is this intentional?

@abhinayagarwal
Copy link
Collaborator

I found out that there is another implementation for empty DialogPane which doesn't have these entries.

@jperedadnr jperedadnr merged commit af8b9a1 into gluonhq:master Oct 29, 2024
6 checks passed
@jperedadnr jperedadnr deleted the 762-metadata branch October 29, 2024 08:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DialogPane hierarchy not shown after #748
3 participants