CSUB-1048 Payouts not displaying #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test before merge -> Staking Dashboad Preview! |
juanma1996
approved these changes
Feb 9, 2024
frankli-dev
force-pushed
the
fix/csub-1048
branch
from
810bac1 to
0a16137
Compare
juanma1996
reviewed
Feb 14, 2024
src/config/networks.ts
Outdated
| subscanEndpoint: 'http://127.0.0.1:4399', | ||
| subscanUrl: 'https://creditcoin3-testnet.subscan.io/', | ||
| subscanEndpoint: 'https://creditcoin3-dev.api.subscan.io', | ||
| subscanUrl: 'https://subscan-cc3-devnet.creditcoin.network', |
There was a problem hiding this comment.
This is the block explorer url, right?
In that case it should be: https://creditcoin3-dev.subscan.io
src/config/networks.ts
Outdated
| subscanEndpoint: 'http://127.0.0.1:4399', | ||
| subscanUrl: 'https://creditcoin3-testnet.subscan.io/', | ||
| subscanEndpoint: 'https://creditcoin3-testnet.api.subscan.io', | ||
| subscanUrl: 'https://subscan-cc3-testnet.creditcoin.network', |
There was a problem hiding this comment.
This is the block explorer url, right?
In that case it should be: https://creditcoin3-testnet.subscan.io
| @@ -123,7 +123,7 @@ const makeNetworkList = () => { | |||
| }, | |||
| namespace: 'creditcoin-mainnet', | |||
| subscanEndpoint: 'http://127.0.0.1:4399', | |||
| subscanUrl: 'https://creditcoin3.subscan.io/', | |||
| subscanUrl: 'https://creditcoin3.subscan.io', | |||
There was a problem hiding this comment.
This need to matches whatever it's on the other networks, I think this one is fine. But just to remember double check it.
| @@ -136,7 +136,7 @@ const makeNetworkList = () => { | |||
| }, | |||
| }, | |||
| subscanEndpoint: 'http://127.0.0.1:4399', | |||
| subscanUrl: 'https://creditcoin3-testnet.subscan.io/', | |||
| subscanUrl: 'https://creditcoin3-testnet.subscan.io', | |||
There was a problem hiding this comment.
This need to matches whatever it's on the other networks, I think this one is fine. But just to remember double check it.
juanma1996
approved these changes
Feb 14, 2024
juanma1996
approved these changes
Feb 14, 2024
pLabarta
approved these changes
Feb 14, 2024
juanma1996
pushed a commit
that referenced
this pull request
Feb 16, 2024
* fix: Subscan api updated * fix: remove last character * fix: Update explorer * fix: Use proxy --------- Co-authored-by: Frank Li <frank.li@gluwa.com>
juanma1996
pushed a commit
that referenced
this pull request
Apr 4, 2024
* fix: Subscan api updated * fix: remove last character * fix: Update explorer * fix: Use proxy --------- Co-authored-by: Frank Li <frank.li@gluwa.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.