Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update marked for security fix #485

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Conversation

kt3k
Copy link
Contributor

@kt3k kt3k commented Nov 25, 2017

marked 0.3.1 seems having 2 known vulnerabilities (1 XSS and 1 ReDoS) and both are fixed at v0.3.4. This PR updates marked to v0.3.4.

See https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2015-8854 and https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2015-1370 for details.

@tripu
Copy link
Collaborator

tripu commented Nov 27, 2017

@kt3k, thank you.
I suggest you upgrade to latest marked (0.3.6) instead, if it's compatible with Remark and tests pass too, to solve yet another vulnerability.

(There's a fourth vulnerability in marked, not yet patched.)

@kt3k kt3k force-pushed the feature/update-marked branch from 2f5ea93 to 1dc8bfa Compare November 28, 2017 00:38
@kt3k
Copy link
Contributor Author

kt3k commented Nov 28, 2017

@tripu Thanks for the comment! I agree with you. Updated it to v0.3.6 👍 ( but it's still vulnerable...

@foxik
Copy link

foxik commented Dec 22, 2017

Note that there is an effort to update marked. The version 0.3.7 has been released and 0.3.9 is hopefully going to be released soon -- markedjs/marked#958.

@kt3k kt3k force-pushed the feature/update-marked branch from 1dc8bfa to 25ba99d Compare December 25, 2017 03:31
@kt3k
Copy link
Contributor Author

kt3k commented Dec 25, 2017

Updated the version to 0.3.9. Thank you @foxik

@tripu
Copy link
Collaborator

tripu commented Dec 26, 2017

Note that marked 0.3.9 is still vulnerable (advisory classified “high”).

@gnab gnab merged commit 4748b03 into gnab:develop Jan 11, 2018
@tripu
Copy link
Collaborator

tripu commented Jan 11, 2018

“Note that marked 0.3.9 is still vulnerable (advisory classified ‘high’).”

Hum, it seems it's not any more… Well, good.

@kt3k kt3k deleted the feature/update-marked branch January 11, 2018 09:33
@kt3k
Copy link
Contributor Author

kt3k commented Jan 11, 2018

It's safe finally! 👏

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants