feat(gnovm): initial inter-realm spec implementation #2958

ltzmaxwell · 2024-10-16T10:22:03Z

address: the inter realm spec part from #2743.

Please refer to the original doc, and #2743 (comment)

And please see the comments below for details of implementation .

Contributors' checklist...

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests

codecov · 2024-10-16T10:23:54Z

Codecov Report

Attention: Patch coverage is 83.40249% with 40 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
gnovm/pkg/gnolang/realm.go	78.14%	28 Missing and 5 partials ⚠️
gnovm/pkg/gnolang/store.go	0.00%	2 Missing and 1 partial ⚠️
gnovm/pkg/gnolang/uverse.go	40.00%	3 Missing ⚠️
gnovm/pkg/gnolang/ownership.go	98.43%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

jefft0 · 2024-10-17T07:19:10Z

(The "review team" label was added by mistake. This PR is opened by a core dev.)

leohhhn · 2025-03-06T05:56:50Z

@thehowl @ltzmaxwell

Are there any specific behavioral patterns in Gno that would be introduced by this PR? If yes, let me know, so I can document them and share with the community.

ltzmaxwell · 2025-03-06T06:04:40Z

@thehowl @ltzmaxwell

Are there any specific behavioral patterns in Gno that would be introduced by this PR? If yes, let me know, so I can document them and share with the community.

there is, I'll provide a short doc for you so that you can expand, as soon as possible.

jaekwon · 2025-03-07T01:32:35Z

look'n

mvertes

Looks good to me
Mainly cosmetic suggestions.

mvertes · 2025-03-07T09:40:40Z

gnovm/pkg/gnolang/ownership.go

+	// If the object is unreal but already owned,
+	// it means the object is bound to this realm
+	// and must be attached to it.
+	// otherwise it zero


Suggested change

// otherwise it zero

gnovm/pkg/gnolang/ownership.go

mvertes · 2025-03-07T09:49:59Z

gnovm/pkg/gnolang/realm.go

 		pkgIDFromPkgPathCache[path] = pkgID
 	}
 	return *pkgID
 }

-// Returns the ObjectID of the PackageValue associated with path.
+// ObjectIDFromPkgPath the [ObjectID] of the [PackageValue] associated with path.


Suggested change

// ObjectIDFromPkgPath the [ObjectID] of the [PackageValue] associated with path.

// ObjectIDFromPkgPath returns the ObjectID of the PackageValue associated with path.

Using [ for emphasis can be confusing. I had to verify that you were not dealing with []ObjecID or []PackageValue.

mvertes · 2025-03-07T09:51:33Z

gnovm/pkg/gnolang/realm.go

 func ObjectIDFromPkgPath(path string) ObjectID {
 	pkgID := PkgIDFromPkgPath(path)
 	return ObjectIDFromPkgID(pkgID)
 }

-// Returns the ObjectID of the PackageValue associated with pkgID.
+// ObjectIDFromPkgID the [ObjectID] of the [PackageValue] associated with pkgID.


Suggested change

// ObjectIDFromPkgID the [ObjectID] of the [PackageValue] associated with pkgID.

// ObjectIDFromPkgID returns the ObjectID of the PackageValue associated with pkgID.

mvertes · 2025-03-07T10:04:00Z

gnovm/pkg/gnolang/realm.go


 	created []Object // about to become real.
 	updated []Object // real objects that were modified.
 	deleted []Object // real objects that became deleted.
 	escaped []Object // real objects with refcount > 1.
 }

-// Creates a blank new realm with counter 0.
+// NewRealm a blank new [Realm] with counter 0.


Suggested change

// NewRealm a blank new [Realm] with counter 0.

// NewRealm creates a blank new Realm.

mvertes · 2025-03-07T10:08:31Z

gnovm/pkg/gnolang/realm.go

+// during a transaction, these actions are recorded through [Realm.DidUpdate].
+// When a realm boundary is exited, then [Realm.FinalizeRealmTransaction] is


Suggested change

// during a transaction, these actions are recorded through [Realm.DidUpdate].

// When a realm boundary is exited, then [Realm.FinalizeRealmTransaction] is

// during a transaction, these actions are recorded through Realm.DidUpdate.

// When a realm boundary is crossed, then Realm.FinalizeRealmTransaction is

mvertes · 2025-03-07T10:11:55Z

gnovm/pkg/gnolang/realm.go

-	ID   PkgID
+	// ID is a constant-sized hash for the realm's package path.
+	ID PkgID
+	// The realm package path.


Suggested change

// The realm package path.

// Path is the realm package path.

mvertes · 2025-03-07T10:14:15Z

gnovm/pkg/gnolang/realm.go

+	// The "Time" of a realm; a variable increased for each new object, in order
+	// to assign it a unique [ObjectID].


Suggested change

// The "Time" of a realm; a variable increased for each new object, in order

// to assign it a unique [ObjectID].

// Time is a counter to provide a unique ObjectID to each new object.

gnovm/pkg/gnolang/realm.go

Co-authored-by: Marc Vertes <mvertes@free.fr>

…nto dev/maxwell/cross-realm

jaekwon · 2025-03-09T00:18:56Z

gnovm/pkg/gnolang/ownership.go

@@ -112,15 +114,16 @@ type Object interface {
 	SetIsDeleted(bool, uint64)
 	GetIsNewReal() bool
 	SetIsNewReal(bool)
+	GetBoundRealm() PkgID


The word "bound" is not used in the inter-realm spec; it is "attached" to the realm.
Confusing vs BoundMethod

jaekwon · 2025-03-09T00:36:29Z

gnovm/pkg/gnolang/ownership.go

+		// is deduced from type, otherwise zero.
+		boundRealm = getPkgId(tv.T)
+	default:
+		// do nothing


panic, so future object types (if any) can be implemented and the panic help ensure to consider the logic here.

jaekwon · 2025-03-09T03:23:46Z

gnovm/pkg/gnolang/ownership.go

+	case *Block:
+		// assert to pointer value
+		if pv, ok := tv.V.(PointerValue); ok {
+			boundRealm = getPkgId(pv.TV.T)


if tv.V.(PointerValue), and tv.GetFirstObject() is *Block,
pv.TV is the thing being pointed to,
but getPkgId(pv.TV.T) has no relation to the block obj.

attachment comes from the LHS, all this logic is coming from the RHS

jaekwon · 2025-03-09T05:11:21Z

gnovm/pkg/gnolang/op_assign.go

@@ -46,7 +46,7 @@ func (m *Machine) doOpAddAssign() {
 	// add rv to lv.
 	addAssign(m.Alloc, lv.TV, rv)
 	if lv.Base != nil {
-		m.Realm.DidUpdate(lv.Base.(Object), nil, nil)
+		m.Realm.DidUpdate(m.Store, lv.Base.(Object), nil, nil)


I don't think it should be necessary to pass store in for inter-realm logic.
There's nothing in the spec that would necessitate loading anything from the store.
https://docs.google.com/document/d/1eCgGPCJ8fMhNc_vc_pbgCxP10X7jGKLC89nBUGatsD4/edit?tab=t.0

If something is in the store it is a RefValue, and from the RefValue you can tell what realm it's attached (stored) to. No need to load anything.

Probably because it's trying to do things from the RHS, and not purely from the LHS, as described here: https://github.com/gnolang/gno/pull/2958/files#r1986207268

I'm making another PR to demonstrate a simpler impl.

…s-realm

ltzmaxwell · 2025-04-03T05:04:45Z

close as fixed by #4037 .

ltzmaxwell added 14 commits June 24, 2024 16:52

naive fix

2dcdfd5

Merge branch 'master' of https://github.com/gnolang/gno

3056bcd

Merge branch 'master' of github.com:gnolang/gno

e69dfc0

Merge branch 'master' of https://github.com/gnolang/gno

9d05216

fix untyped bool

fb2f408

revert un-intentional change

22f973f

test files

2926b3d

debug

c3e3bdd

debug

72b28d7

save

00a59e7

external type

71c6fed

save

07d9029

save

8fdc399

more test

a604cdc

ltzmaxwell requested review from jaekwon, moul, piux2, thehowl, mvertes and a team as code owners October 16, 2024 10:22

github-actions bot assigned ltzmaxwell Oct 16, 2024

github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Oct 16, 2024

jefft0 added review/triage-pending PRs opened by external contributors that are waiting for the 1st review and removed review/triage-pending PRs opened by external contributors that are waiting for the 1st review labels Oct 16, 2024

ltzmaxwell added the in focus label Oct 19, 2024

zivkovicmilos added this to the 🚀 Mainnet launch milestone Oct 28, 2024

ltzmaxwell added 3 commits March 6, 2025 19:53

skip escaped check

223d403

sync

06aff90

fmt

786623d

thehowl changed the title ~~feat: PoC of inter-realm spec~~ feat: initial inter-realm spec implementation Mar 6, 2025

thehowl changed the title ~~feat: initial inter-realm spec implementation~~ feat(gnovm): initial inter-realm spec implementation Mar 6, 2025

ltzmaxwell added 3 commits March 7, 2025 15:45

revert ops log; add comment

c7566c9

fix txtar after revert opslog

9bd6731

fixup

9e6077c

mvertes approved these changes Mar 7, 2025

View reviewed changes

ltzmaxwell and others added 4 commits March 7, 2025 18:54

Update gnovm/pkg/gnolang/ownership.go

a7e6937

Co-authored-by: Marc Vertes <mvertes@free.fr>

Update gnovm/pkg/gnolang/realm.go

84936a6

Co-authored-by: Marc Vertes <mvertes@free.fr>

revert revert opslog

be0a738

Merge branch 'dev/maxwell/cross-realm' of github.com:ltzmaxwell/gno i…

6368721

…nto dev/maxwell/cross-realm

jaekwon reviewed Mar 9, 2025

View reviewed changes

This was linked to issues Mar 11, 2025

setting a closure across realm boundaries marks an entire block as owned by the called realm #3693

Closed

Gno Realm and Ownership Spec #2743

Closed

Kouteki moved this from In Review to In Progress in 🧙‍♂️gno.land core team Mar 17, 2025

Merge branch 'master' of github.com:gnolang/gno into dev/maxwell/cros…

dd1687f

…s-realm

thehowl mentioned this pull request Mar 18, 2025

feat: alternative inter-realm implementation #3971

Closed

moul mentioned this pull request Mar 20, 2025

WIP feat: crossrealm alternative #3984

Draft

ltzmaxwell closed this Apr 3, 2025

github-project-automation bot moved this from In Progress to Done in 💪 Bounties & Worx Apr 3, 2025

github-project-automation bot moved this from In Progress to Done in 🧙‍♂️gno.land core team Apr 3, 2025

	// ObjectIDFromPkgPath the [ObjectID] of the [PackageValue] associated with path.
	// ObjectIDFromPkgPath returns the ObjectID of the PackageValue associated with path.

	// ObjectIDFromPkgID the [ObjectID] of the [PackageValue] associated with pkgID.
	// ObjectIDFromPkgID returns the ObjectID of the PackageValue associated with pkgID.

	// NewRealm a blank new [Realm] with counter 0.
	// NewRealm creates a blank new Realm.

		// during a transaction, these actions are recorded through [Realm.DidUpdate].
		// When a realm boundary is exited, then [Realm.FinalizeRealmTransaction] is

	// The realm package path.
	// Path is the realm package path.

		// The "Time" of a realm; a variable increased for each new object, in order
		// to assign it a unique [ObjectID].

	// The "Time" of a realm; a variable increased for each new object, in order
	// to assign it a unique [ObjectID].
	// Time is a counter to provide a unique ObjectID to each new object.

feat(gnovm): initial inter-realm spec implementation #2958

feat(gnovm): initial inter-realm spec implementation #2958

Uh oh!

Conversation

ltzmaxwell commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jefft0 commented Oct 17, 2024

Uh oh!

leohhhn commented Mar 6, 2025

Uh oh!

ltzmaxwell commented Mar 6, 2025

Uh oh!

jaekwon commented Mar 7, 2025

Uh oh!

mvertes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ltzmaxwell commented Apr 3, 2025

Uh oh!

Uh oh!

ltzmaxwell commented Oct 16, 2024 •

edited

Loading

codecov bot commented Oct 16, 2024 •

edited

Loading