Skip to content

x: grc721 full refactor #63

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 16 commits into from
Closed

x: grc721 full refactor #63

wants to merge 16 commits into from

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Apr 5, 2024

Description

This is a refactor of the GRC721 package. The idea with this is that we want a fully "by-spec" implementation, and then we can build upon it and experiment.

The process of writing is done in Go, and later converted to Gno.

@linhpn99
Copy link

Can you assign me some issues to solve together ?

@n0izn0iz
Copy link

n0izn0iz commented Apr 23, 2024

wdyt about using []byte as tokenId type?
It would be a superset of eth's uint256 while allowing tokens to have more self-describing and expressive keys
I guess it would be annoying to bridge gno nfts to ethereum on the other hand

@leohhhn leohhhn self-assigned this May 8, 2024
@leohhhn leohhhn marked this pull request as ready for review May 8, 2024 16:14
@leohhhn
Copy link
Contributor Author

leohhhn commented May 9, 2024

Hey @linhpn99 @n0izn0iz,

I've finished the implementation for this and added an example usage realm. If you want, you can take a look and tell me what you think.

@leohhhn
Copy link
Contributor Author

leohhhn commented May 9, 2024

Will move this code to the monorepo for visibility :)

@linhpn99
Copy link

linhpn99 commented May 9, 2024

Will move this code to the monorepo for visibility :)

Hey @linhpn99 @n0izn0iz,

I've finished the implementation for this and added an example usage realm. If you want, you can take a look and tell me what you think.

is it safe that you call panic() when handling the exception ?

@leohhhn
Copy link
Contributor Author

leohhhn commented May 16, 2024

@linhpn99 @n0izn0iz

Moved it to the monorepo.

Is it safe that you call panic() when handling the exception?

Will reply on the monorepo

@leohhhn leohhhn closed this Jun 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants