Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: recoverer middleware skip write header on upgrade connection #795

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

fatelei
Copy link
Contributor

@fatelei fatelei commented Feb 15, 2023

Fix #661

skip write header when connection has been upgrade

Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkieltyka pkieltyka merged commit 51068a7 into go-chi:master Feb 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

middlewear.Recover causes undefined behaviour if a connection has been upgraded.
3 participants