fix(WrapResponseWriter): allow multiple informational statuses #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costela
changed the title
costela
changed the title
VojtechVitek
reviewed
Dec 3, 2024
middleware/wrap_writer.go
Outdated
| @@ -81,6 +81,10 @@ type basicWriter struct { | |||
| } | |||
|
|
|||
| func (b *basicWriter) WriteHeader(code int) { | |||
| if code >= 100 && code <= 199 && code != http.StatusSwitchingProtocols { | |||
| b.ResponseWriter.WriteHeader(code) | |||
There was a problem hiding this comment.
I think we're missing if !b.discard {, same as below
There was a problem hiding this comment.
ah, you're right! Fixed. PTAL
Informational status in the range 100-199 may be sent multiple times, unlike statuses in the range 200-599. This follows usage in the stdlib: https://github.com/golang/go/blob/485ed2fa5b5e0b7067ef72a0f4bdc9ca12b77ed7/src/net/http/server.go#L1216
costela
force-pushed
the
fix-wrapresponsewriter-writing-multiple-informational-statuses
branch
from
3ea3720 to
45de05a
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informational status in the range 100-199 may be sent multiple times, unlike statuses in the range 200-599.
This follows usage in the stdlib:
https://github.com/golang/go/blob/485ed2fa5b5e0b7067ef72a0f4bdc9ca12b77ed7/src/net/http/server.go#L1216
See also docs on
WriteHeader(emphasis added):