Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fallback on all Redis errors #16

Merged
merged 8 commits into from
Aug 8, 2024
Merged

Fallback on all Redis errors #16

merged 8 commits into from
Aug 8, 2024

Conversation

VojtechVitek
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Benchmark Results

goos: linux
goarch: amd64
pkg: github.com/go-chi/httprate-redis
cpu: AMD EPYC 7763 64-Core Processor                
               │ master.txt  │
               │   sec/op    │
LocalCounter-4   2.007 ± 85%

               │  master.txt   │
               │     B/op      │
LocalCounter-4   16.30Mi ± 61%

               │  master.txt  │
               │  allocs/op   │
LocalCounter-4   240.4k ± 37%

@VojtechVitek VojtechVitek force-pushed the aPE590e9 branch 2 times, most recently from a0dafe9 to 1f19b64 Compare August 8, 2024 15:23
@VojtechVitek
Copy link
Contributor Author

I'll disable benchmark in the CI, as Github Actions are clearly rate-limiting the CPU / network too much:

Screen Shot 2024-08-08 at 5 35 52 PM

Compared to my localhost:
Screen Shot 2024-08-08 at 5 36 06 PM

@VojtechVitek VojtechVitek merged commit 1ab0ec2 into master Aug 8, 2024
2 checks passed
@VojtechVitek VojtechVitek deleted the aPE590e9 branch August 8, 2024 15:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VojtechVitek