-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Split an Engine
struct from the existing Server
struct.
#280
Comments
FYI plan to read this maybe tomorrow or Saturday morning. Day job is getting in the way this week. |
I don't think we should be opinionated on what other frameworks do. We'd easily end up withe N+1 problem where we'd need to implement things per framework, "Engine", we want to plug in. For instance #293 I was thinking about how this could interact with gin/echo and came to the conclusion it just wouldn't also the users coming from those communities probably have a logger they adore why fight it. I really like this |
Yeah we have to remember to stick mostly to I see gin/echo compatibility (the |
Fixed in #290 |
As you know, I'm working on other frameworks integration. I thought that splitting the OpenAPI struct would be enough but it isn't.
I currently am re-writing some bits of Fuego's error handling for Gin but I think I shouldn't.
I think we need to split Server (again!) to be able to plug more easily new Frameworks.
This will allow to re-code the bare minimum when creating bindings for other routers!!! We will be able to plug any router and also keep Fuego's philosophy as per #263.
Of course :
The text was updated successfully, but these errors were encountered: