Moved all non-net/http related code to the new Engine struct #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenQuim
force-pushed
the
engine
branch
2 times, most recently
from
5561d9b to
ccd967b
Compare
Merged
dylanhitt
approved these changes
Dec 20, 2024
This was referenced Dec 21, 2024
Closed
Ignaciojeria
pushed a commit
to Ignaciojeria/fuego
that referenced
this pull request
Dec 26, 2024
Ignaciojeria
pushed a commit
to Ignaciojeria/fuego
that referenced
this pull request
Dec 26, 2024
Ignaciojeria
pushed a commit
to Ignaciojeria/fuego
that referenced
this pull request
Dec 26, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.
It's not a lot haha, and we could have expected this, because we're really close to
net/http. The next step will be to fit our Content-Negociation into this Engine. But we'll release the Gin compatibility package before as it's not the end if it only supportsapplication/jsonfor a few weeks.