Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Generic main handler #300

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Generic main handler #300

merged 4 commits into from
Dec 22, 2024

Conversation

EwenQuim
Copy link
Member

@EwenQuim EwenQuim commented Dec 22, 2024

Please look at the Pull Request in your IDE, the default Github diff is ugly.

This PR is made to make the previous Fuego net/http flow with validation, error handling... generic. It only uses Fuego's abstractions (the new Engine, ContextWithBody, and the good old fuego controller).

I will then move flow to internal and reuse it in the gin extension.

@EwenQuim EwenQuim requested a review from dylanhitt December 22, 2024 09:28
@EwenQuim EwenQuim mentioned this pull request Dec 22, 2024
@EwenQuim EwenQuim force-pushed the generic-main-handler branch from f1c3aaa to 6d898cc Compare December 22, 2024 09:30
@EwenQuim EwenQuim mentioned this pull request Dec 22, 2024
@EwenQuim EwenQuim force-pushed the generic-main-handler branch from 6d898cc to 405e625 Compare December 22, 2024 09:34
@EwenQuim EwenQuim force-pushed the generic-main-handler branch 2 times, most recently from 9529a63 to 48f4f94 Compare December 22, 2024 11:42
@EwenQuim EwenQuim force-pushed the generic-main-handler branch from 48f4f94 to 2329fb2 Compare December 22, 2024 11:45
@EwenQuim
Copy link
Member Author

Merging because I have too much PRs in parallel and I want to continue, but don't hesitate to send post-merging comments!!!

@EwenQuim EwenQuim merged commit c10561b into main Dec 22, 2024
6 of 7 checks passed
@EwenQuim EwenQuim deleted the generic-main-handler branch December 22, 2024 11:48
@EwenQuim
Copy link
Member Author

See usage in 4f55b62

Ignaciojeria pushed a commit to Ignaciojeria/fuego that referenced this pull request Dec 26, 2024
* Rely on Context to build main Fuego controller response

* Makes main handler generic

* Generic Fuego main handler

* Hide Serialize and SerializeError from the public API
Ignaciojeria pushed a commit to Ignaciojeria/fuego that referenced this pull request Dec 26, 2024
* Rely on Context to build main Fuego controller response

* Makes main handler generic

* Generic Fuego main handler

* Hide Serialize and SerializeError from the public API
Ignaciojeria pushed a commit to Ignaciojeria/fuego that referenced this pull request Dec 26, 2024
* Rely on Context to build main Fuego controller response

* Makes main handler generic

* Generic Fuego main handler

* Hide Serialize and SerializeError from the public API
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant