Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Diff background color line numbers #14603

Closed
KN4CK3R opened this issue Feb 7, 2021 · 8 comments · Fixed by #30670
Closed

Diff background color line numbers #14603

KN4CK3R opened this issue Feb 7, 2021 · 8 comments · Fixed by #30670
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@KN4CK3R
Copy link
Member

KN4CK3R commented Feb 7, 2021

#13922 removed the background color of the line numbers. Was this change intended? GitHub and GitLab use different colors for the line numbers too.

Screenshots

1.13:
grafik

1.14:
grafik

https://github.com/go-gitea/gitea/pull/13922/files#diff-109c70f0162741a5b3de595e88e23d39646b364750956dd6a99ab50b997869beL1610-L1629
@sharpSteff
Copy link

Imo it is quite hard to work without the background color of the lines.
This should be configurable...

@lunny
Copy link
Member

lunny commented Jun 2, 2021

@silverwind Can you explain some reason here or it's not a problem any more?

@silverwind
Copy link
Member

It was semi-intentional but I agree we should add it back.

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jun 3, 2021
@ston1th
Copy link

ston1th commented Oct 9, 2021

@lunny @silverwind
May I kindly ask what the status of this issue is?

I really would like to have the old colors back or even better the colors github is using.
IMHO they are the best to look at.

@wxiaoguang
Copy link
Contributor

These colors have been gone for long time ..... do we still need them?

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 26, 2023
@silverwind
Copy link
Member

silverwind commented Apr 26, 2023 •
edited
Loading

Hmm I do think they give a bit of distinction between what is line number and what isn't, so I still see them useful. But when we add them back, we also need to alter expander colors to match in shade. So likely this will be at minimum 3 new CSS vars.

@GiteaBot
Copy link
Collaborator

GiteaBot commented Sep 8, 2023

We close issues that need feedback from the author if there were no new comments for a month. 🍵

@GiteaBot GiteaBot closed this as completed Sep 8, 2023
@KN4CK3R KN4CK3R reopened this Sep 8, 2023
@jolheiser jolheiser removed the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Sep 8, 2023
@silverwind
Copy link
Member

Still something that should be done.

@KN4CK3R KN4CK3R mentioned this issue Apr 25, 2024
Merged
silverwind added a commit that referenced this issue Apr 26, 2024
@silverwind
Diff color enhancements, add line number background (#30670)
c93eefb 
1. Bring back the background on line numbers. This feature was lost a
long time ago.

<img width="457" alt="Screenshot 2024-04-24 at 01 36 09"
src="https://github.com/go-gitea/gitea/assets/115237/76a7f5a9-c22a-4c72-9f0a-ebf16a66513e">
<img width="473" alt="Screenshot 2024-04-24 at 01 22 47"
src="https://github.com/go-gitea/gitea/assets/115237/eef06cf2-f1b9-40e3-947d-dd5852ec12a3">
<img width="457" alt="Screenshot 2024-04-24 at 02 13 18"
src="https://github.com/go-gitea/gitea/assets/115237/59e317d4-76a7-468c-8a19-10d88c675cc3">
<img width="459" alt="Screenshot 2024-04-24 at 01 23 21"
src="https://github.com/go-gitea/gitea/assets/115237/f1a46f8d-8846-4d78-a9d7-8b7dc18ac6e4">

2. Expanded lines background is now full-line, including line numbers:

<img width="1303" alt="Screenshot 2024-04-24 at 01 37 12"
src="https://github.com/go-gitea/gitea/assets/115237/271eefe2-0869-424e-93fb-ccd8adc87806">

3. Sort affected colors alphabetically in the CSS

Fixes #14603
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 25, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Diff color enhancements, add line number background silverwind/gitea
8 participants
@lunny @silverwind @KN4CK3R @wxiaoguang @ston1th @GiteaBot @sharpSteff @jolheiser