Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Proposal : Improve left tree view #24766

Closed
Kiiow opened this issue May 17, 2023 · 6 comments · Fixed by #27593
Closed

Proposal : Improve left tree view #24766

Kiiow opened this issue May 17, 2023 · 6 comments · Fixed by #27593
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Comments

@Kiiow
Copy link

Kiiow commented May 17, 2023

Description

The current tree view that we can see on PRs and commits is really cool and help navigate in different files esaily, but it's hard to spot in which folder level a file is.

It would be interesting to improve the padding on the list and add guideline to see faster in which folder a file is.

Screenshots

before

I've made the modification directly in the browser using the devtools, but i don't know which css files need to be edited to get something like that.

What i've done is:

/* Remove */
.item.filewrapper {
  padding-left: 18px!important;
}
/* Add */
.ui.list .list:not(.icon) {
  padding-left: 0.75em;
  margin-left: 10px;
  border-left: 1px solid #679169;
}

after_insepct_improve

Gitea Version

1.19.0+62-g809225113

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Windows

Browser Version

Brave Version 1.51.114 Chromium: 113.0.5672.92

@Kiiow Kiiow added type/bug topic/ui Change the appearance of the Gitea UI labels May 17, 2023
@silverwind
Copy link
Member

silverwind commented May 17, 2023

I agree we can add these, but we should use a subtle secondary color. For reference, GitHub also has these, but their color is a bit too subtle. Also we should not increase indendation too much. Space is limited and we need to support deeply nested structures.

image

@silverwind silverwind added type/enhancement An improvement of existing functionality proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. and removed type/bug labels May 17, 2023
@lozn00

This comment was marked as off-topic.

@lunny

This comment was marked as off-topic.

@lozn00

This comment was marked as off-topic.

@lunny

This comment was marked as off-topic.

@lozn00

This comment was marked as off-topic.

@lunny lunny closed this as completed Sep 5, 2023
@lunny lunny reopened this Sep 5, 2023
lunny pushed a commit that referenced this issue Oct 25, 2023
…27593)

## Add border to file tree 'sub-items'
close #24766 
view in `gitea-light` 
<img width="275" alt="image"
src="https://github.com/go-gitea/gitea/assets/70063547/f1bf8736-2db3-454f-86f5-d050a2fae3eb">
view in `gitea-dark`
<img width="296" alt="image"
src="https://github.com/go-gitea/gitea/assets/70063547/053e2e6e-28f7-41d2-a139-1dae4df45929">
## Change the 'item-file' padding 
Before that the 'item-file' only have padding when they in
'item-directory', which is too compact when 'item-file' after
'item-directory'
<details>

![)RW`SDJ_UQL@$}0
PL(3DS7](https://github.com/go-gitea/gitea/assets/70063547/5fa523a4-44c3-4cb9-a882-a3ea6d944673)

---------

Co-authored-by: silverwind <me@silverwind.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
…o-gitea#27593)

## Add border to file tree 'sub-items'
close go-gitea#24766 
view in `gitea-light` 
<img width="275" alt="image"
src="https://github.com/go-gitea/gitea/assets/70063547/f1bf8736-2db3-454f-86f5-d050a2fae3eb">
view in `gitea-dark`
<img width="296" alt="image"
src="https://github.com/go-gitea/gitea/assets/70063547/053e2e6e-28f7-41d2-a139-1dae4df45929">
## Change the 'item-file' padding 
Before that the 'item-file' only have padding when they in
'item-directory', which is too compact when 'item-file' after
'item-directory'
<details>

![)RW`SDJ_UQL@$}0
PL(3DS7](https://github.com/go-gitea/gitea/assets/70063547/5fa523a4-44c3-4cb9-a882-a3ea6d944673)

---------

Co-authored-by: silverwind <me@silverwind.io>
silverwind added a commit to silverwind/gitea that referenced this issue Feb 20, 2024
…o-gitea#27593)

## Add border to file tree 'sub-items'
close go-gitea#24766 
view in `gitea-light` 
<img width="275" alt="image"
src="https://github.com/go-gitea/gitea/assets/70063547/f1bf8736-2db3-454f-86f5-d050a2fae3eb">
view in `gitea-dark`
<img width="296" alt="image"
src="https://github.com/go-gitea/gitea/assets/70063547/053e2e6e-28f7-41d2-a139-1dae4df45929">
## Change the 'item-file' padding 
Before that the 'item-file' only have padding when they in
'item-directory', which is too compact when 'item-file' after
'item-directory'
<details>

![)RW`SDJ_UQL@$}0
PL(3DS7](https://github.com/go-gitea/gitea/assets/70063547/5fa523a4-44c3-4cb9-a882-a3ea6d944673)

---------

Co-authored-by: silverwind <me@silverwind.io>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants