Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Cannot click on action link if the commit message is empty #27901

Closed
ldicarlo opened this issue Nov 4, 2023 · 1 comment · Fixed by #28113
Closed

Cannot click on action link if the commit message is empty #27901

ldicarlo opened this issue Nov 4, 2023 · 1 comment · Fixed by #28113
Labels
topic/gitea-actions related to the actions of Gitea type/bug

Comments

@ldicarlo
Copy link

ldicarlo commented Nov 4, 2023 •
edited
Loading

Description

When I commit using git commit --allow-empty-message -m ""
Then I cannot click on the link in the associated action.
The resulting html element is
<a class="index gt-no-underline title action-item-title" title="" href="/<AUTHOR>/<REPO>/actions/runs/1"></a>

Maybe we should have a placeholder here in case of missing message?

But this is really not a big problem, I just write it here so you know, but it is really minor.

Gitea Version

1.20.5

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

NixOS

How are you running Gitea?

using nix official gitea service

Database

PostgreSQL
@silverwind
Copy link
Member

Maybe <empty commit message> placeholder. Likely this issue affects more places than just this list, so a shared template would be good to make it re-usable elsewhere.

@lunny lunny added the topic/gitea-actions related to the actions of Gitea label Nov 5, 2023
@lunny lunny mentioned this issue Nov 18, 2023
Merged
lunny added a commit that referenced this issue Nov 21, 2023
@lunny
Fix empty action run title (#28113)
0c0d17f 
Fix #27901
@GiteaBot GiteaBot mentioned this issue Nov 21, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Nov 21, 2023
@lunny @GiteaBot
Fix empty action run title (go-gitea#28113)
81c8985 
Fix go-gitea#27901
lunny added a commit that referenced this issue Nov 21, 2023
@GiteaBot @lunny
Fix empty action run title (#28113) (#28148)
c997e90 
Backport #28113 by @lunny

Fix #27901

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
silverwind pushed a commit to silverwind/gitea that referenced this issue Nov 21, 2023
@lunny @silverwind
Fix empty action run title (go-gitea#28113)
98912e9 
Fix go-gitea#27901
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2024
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@lunny @fuxiaohei
Fix empty action run title (go-gitea#28113)
34f8041 
Fix go-gitea#27901
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@lunny @silverwind
Fix empty action run title (go-gitea#28113)
7788b95 
Fix go-gitea#27901
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@GiteaBot @earl-warren
Fix empty action run title (go-gitea#28113) (go-gitea#28148)
4da95b7 
Backport go-gitea#28113 by @lunny

Fix go-gitea#27901

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
(cherry picked from commit c997e90)
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix empty action run title lunny/gitea
3 participants
@lunny @silverwind @ldicarlo