gitea doctor will remove repo-avatar files

[eeyrjmr]

Description

if a user configures a repo to have a custom avatar then gitea doctor check --fix --all deletes the associated avatar files.

STARTING CASE:

jupyterlab icon added to a repo

blob is found on the filesystem.

gitea doctor check --fix --all is executed and completes.

the repo-avatar directory is now empty.

viewing with a browser confirms the avatar is missing.

LEFT is chrome using cached image, RIGHT is incognito mode.

The behaviour of services/doctor/storage.go implies that orphaned files will be deleted
https://github.com/go-gitea/gitea/blob/e3e08dcc5184cdbdac5023fabaafba123a995c3e/services/doctor/storage.go#L92C1-L93C1

how to indicate that repo-avatars are not orphan files.

sidenote... what else could be classed as orphaned and incorrectly removed

Gitea Version

1.21.9

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

windows and linux

Database

MySQL/MariaDB

[yp05327]

Doctor handles the object id as storage path, but repo archiver needs relative path:


Then it will be detected as invalid storage path and will be deleted.

[lunny]

Doctor handles the object id as storage path, but repo archiver needs relative path: Then it will be detected as invalid storage path and will be deleted.

Can you send a PR to fix it?

[yp05327]

yeah, but it seems that the root reason is typo 😂

[yp05327]

By my test, if you reupload the same file, it will have no changes.
You need to reupload another one first, then reupload the original file.