Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CleanupLogs infinite loop #33567

Closed
ericLemanissier opened this issue Feb 12, 2025 · 3 comments
Closed

CleanupLogs infinite loop #33567

ericLemanissier opened this issue Feb 12, 2025 · 3 comments
Labels
Milestone

Comments

@ericLemanissier
Copy link
Contributor

Description

I'm in a situation where the CRON task "Cleanup expired actions resources" has been running for 9 hours, and seems to be continually trying to delete the same 100 log files, but always failing with ..s/actions/cleanup.go:105:CleanupLogs() [E] Failed to remove log ... (in storage false) of task ...: dbfs remove "...": file does not exist
I don't know why these file do not exist, but certainly the failure to delete them could be simply ignored in this case, and continue with the rest of this task's cleanup ?

Gitea Version

1.23.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

https://gist.github.com/ericLemanissier/b7377035b5fdcad1e7de8ec21dbeef3c

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

SQLite

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 12, 2025

I think we need to backport this to 1.23

Skip deletion error for action artifacts #33476


For 1.23: #33568

And if you don't mind and don't want to wait, maybe you could try the development version "main-nightly" build (which will be 1.24 in a few months ....)

@ericLemanissier
Copy link
Contributor Author

oh this has already been fixed, great !
I cannot try development versions, but I'll migrate to the first version with the fix when it's available, be it 1.24.0 or 1.23.4. Thanks !

@lunny lunny added this to the 1.23.4 milestone Feb 12, 2025
@lunny
Copy link
Member

lunny commented Feb 12, 2025

Closed by #33568

@lunny lunny closed this as completed Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants