Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change admin dashboard to POST #10465

Merged
merged 3 commits into from
Feb 25, 2020
Merged

Change admin dashboard to POST #10465

merged 3 commits into from
Feb 25, 2020

Conversation

jolheiser
Copy link
Member

No description provided.

@jolheiser
Add form and convert to POST
f59189a 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser
Redirect for flash
5fd26e5 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser
Merge branch 'master' of https://github.com/go-gitea/gitea into jolhe…
1aa59c2 
…iser-fix-admin
@jolheiser jolheiser added this to the 1.12.0 milestone Feb 25, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 25, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@5fd26e5). Click here to learn what that means.
The diff coverage is 67.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10465   +/-   ##
=========================================
  Coverage          ?    43.7%           
=========================================
  Files             ?      586           
  Lines             ?    81419           
  Branches          ?        0           
=========================================
  Hits              ?    35585           
  Misses            ?    41430           
  Partials          ?     4404
Impacted Files Coverage Δ
routers/api/v1/repo/tag.go 86.58% <100%> (ø)
routers/routes/routes.go 86.27% <100%> (ø)
modules/git/repo_tag.go 57.57% <18.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd26e5...1aa59c2. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2020
@jolheiser jolheiser merged commit e5944a9 into go-gitea:master Feb 25, 2020
@6543
Copy link
Member

6543 commented Feb 25, 2020

Please send backport ;)

@jolheiser jolheiser deleted the jolheiser-fix-admin branch February 25, 2020 22:57
jolheiser added a commit to jolheiser/gitea that referenced this pull request Feb 25, 2020
@jolheiser
Change admin dashboard to POST (go-gitea#10465)
6903602 
* Add form and convert to POST

* Redirect for flash

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser mentioned this pull request Feb 25, 2020
Merged
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Feb 25, 2020
jolheiser added a commit that referenced this pull request Feb 25, 2020
@jolheiser
Change admin dashboard to POST (#10465) (#10466)
ed664a9 
* Change admin dashboard to POST (#10465)

* Add form and convert to POST

* Redirect for flash

* Convert octicons back to fa for 1.11

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@zeripath zeripath mentioned this pull request Feb 27, 2020
Closed
7 tasks
This was referenced Mar 2, 2020
Closed
Closed
@zeripath zeripath added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Mar 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jolheiser @codecov-io @6543 @zeripath @GiteaBot