Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename ctx.User to ctx.Doer #19161

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Rename ctx.User to ctx.Doer #19161

merged 3 commits into from
Mar 22, 2022

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Mar 21, 2022

As discussed in #18798 (comment)

I did not find a direct use of User in the templates. There is only SignedUser but that name may be ok.

@KN4CK3R KN4CK3R added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 21, 2022
@KN4CK3R KN4CK3R mentioned this pull request Mar 21, 2022
@codecov-commenter

This comment was marked as outdated.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 21, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 22, 2022
@6543 6543 added this to the 1.17.0 milestone Mar 22, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2022
@lunny
Copy link
Member

lunny commented Mar 22, 2022

make L-G-T-M work

@lunny lunny merged commit 80fd255 into go-gitea:main Mar 22, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 22, 2022
* giteaofficial/main:
  Fix the bug: deploy key with write access can not push (go-gitea#19010)
  Renamed ctx.User to ctx.Doer. (go-gitea#19161)
  [docs] Enhance container selection in docker dump (go-gitea#14292)
  Cleanup protected branches when deleting users & teams (go-gitea#19158)
  Reorder issue templates and automatically add labels (go-gitea#18875)
  Use IterateBufferSize whilst querying repositories during adoption check (go-gitea#19140)
@KN4CK3R KN4CK3R deleted the refactor-doer branch March 23, 2022 07:52
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants