Fix dump-repo git init, fix wrong error type for NullDownloader
#20182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Jun 30, 2022
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Jun 30, 2022
GiteaBot
added
lgtm/done
This was referenced Jun 30, 2022
wxiaoguang
added
backport/done
wxiaoguang
changed the title
dump-repo git initdump-repo git init, fix wrong error type for NullDownloader
|
Sorry for bothering , but one more fix: func IsErrNotSupported(err error) bool {
_, ok := err.(ErrNotSupported)
...
// then in NullDownloader:
return nil, &ErrNotSupported{}
}The NullDownloader should return the struct instead of the pointer. |
delvh
approved these changes
Jun 30, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 1, 2022
* upstream/main: Fix cli command restore-repo: "units" should be splitted to string slice, to match the old behavior and match the dump-repo's behavior (go-gitea#20183) [skip ci] Updated translations via Crowdin Fix `dump-repo` git init, fix wrong error type for NullDownloader (go-gitea#20182) Check if project has the same repository id with issue when assign project to issue (go-gitea#20133) [skip ci] Updated translations via Crowdin
6543
pushed a commit
that referenced
this pull request
Jul 1, 2022
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
…-gitea#20182) * Fix `dump-repo` git init * fix wrong error type for NullDownloader
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a new dependency of git module.
The
dump-reposub-command should initialize the git module before calling git commands.And NullDownloader returned wrong error type, which stops dump-repo command, it's fixed together.
ps: keeping the
var git.DefaultContext = nilis by purpose, it will help to find all uninitialized calls to git module.