Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix table misalignments and tweak webhook and githook lists #21917

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 23, 2022

  • Fix regression from Webhook list enhancements #21893 which had misaligned a few tables like repo lists and e-mails
  • Bring githooks list in line with webhooks list for styling
  • Change webhook list icons to just colored dots, like githook list
  • Increase size of dot in webhook and githook list from 16 to 22px

Screenshot 2022-11-23 at 21 17 09

Screenshot 2022-11-23 at 21 17 39

Screenshot 2022-11-23 at 21 13 12

- Fix regression from go-gitea#21893 which had misaligned a few tables like repo
  lists and e-mails
- Bring githooks list in line with webhooks list for styling
- Change webhook list icons to just colored dots, like githook list
- Increase size of dot in webhook and githook list from 16 to 22px
@silverwind silverwind added type/bug type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Nov 23, 2022
@silverwind silverwind added this to the 1.19.0 milestone Nov 23, 2022
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 23, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 23, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 24, 2022
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 24, 2022
@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit b97548a into go-gitea:main Nov 24, 2022
@silverwind silverwind deleted the settings-table branch November 24, 2022 07:08
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 24, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 25, 2022
* giteaofficial/main:
  Workaround for container registry push/pull errors (go-gitea#21862)
  Fix scroll over mermaid frame (go-gitea#21925)
  Add support for HEAD requests in Maven registry (go-gitea#21834)
  Fix button in branch list, avoid unexpected page jump before restore branch actually done (go-gitea#21562)
  Fix typo in sidebar (go-gitea#21922)
  Fix table misalignments and tweak webhook and githook lists (go-gitea#21917)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants