Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: add Edit this page #21981

Merged
merged 7 commits into from Dec 3, 2022
Merged

docs: add Edit this page #21981

merged 7 commits into from Dec 3, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 30, 2022

Update theme to support Edit this page:
https://gitea.com/gitea/theme/pulls/116

Screenshot:
Edit this page

Signed-off-by: Xinyu Zhou i@sourcehut.net

Update theme:
https://gitea.com/gitea/theme/pulls/116

Signed-off-by: Xinyu Zhou <i@sourcehut.net>
@ghost ghost added the type/docs This PR mainly updates/creates documentation label Nov 30, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 30, 2022
docs/config.yaml Outdated
@@ -23,6 +23,8 @@ params:
goVersion: 1.19
minNodeVersion: 14
search: nav
github_doc_repository: "https://github.com/go-gitea/gitea"
github_doc_repository_path: "docs/content"
Copy link
Member

@silverwind silverwind Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be renamed to repoand docContentPath? I think it would be more fitting. camelCase to follow existing vars.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Xinyu Zhou <i@sourcehut.net>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2022
@jolheiser
Copy link
Member

jolheiser commented Nov 30, 2022

Does this PR also require the partial, like was done in the theme repo? Docs build is failing in CI.

@zeripath
Copy link
Contributor

yup it looks like something is missing:

Building sites … ERROR 2022/11/30 18:36:32 render of "page" failed: "/drone/src/docs/themes/gitea/layouts/doc/single.html:14:8": execute of template failed: template: doc/single.html:14:8: executing "doc/single.html" at <partial "edit_this_page" .>: error calling partial: partial "edit_this_page" not found
ERROR 2022/11/30 18:36:32 render of "page" failed: "/drone/src/docs/themes/gitea/layouts/doc/single.html:14:8": execute of template failed: template: doc/single.html:14:8: executing "doc/single.html" at <partial "edit_this_page" .>: error calling partial: partial "edit_this_page" not found
ERROR 2022/11/30 18:36:32 render of "page" failed: "/drone/src/docs/themes/gitea/layouts/page/single.html:14:8": execute of template failed: template: page/single.html:14:8: executing "page/single.html" at <partial "edit_this_page" .>: error calling partial: partial "edit_this_page" not found
ERROR 2022/11/30 18:36:32 render of "page" failed: "/drone/src/docs/themes/gitea/layouts/doc/single.html:14:8": execute of template failed: template: doc/single.html:14:8: executing "doc/single.html" at <partial "edit_this_page" .>: error calling partial: partial "edit_this_page" not found

@ghost ghost changed the title docs: add Edit on GitHub docs: add Edit this Page Dec 2, 2022
@ghost ghost changed the title docs: add Edit this Page docs: add Edit this page Dec 2, 2022
@lunny
Copy link
Member

lunny commented Dec 3, 2022

make L-G-T-M work

@lunny lunny merged commit 181f4bf into go-gitea:main Dec 3, 2022
@ghost ghost deleted the docs/edit-on-github branch December 3, 2022 12:47
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 3, 2022
* giteaofficial/main:
  docs: add `Edit this page` (go-gitea#21981)
  refactor some functions to support ctx as first parameter (go-gitea#21878)
  Remove deprecated packages & staticcheck fixes (go-gitea#22012)
  Add pnpm to packages/overview (go-gitea#22008)
  Update to Alpine 3.17 (go-gitea#21904)
  Update gitea-vet to check FSFE REUSE (go-gitea#22004)
  Multiple improvements for comment edit diff (go-gitea#21990)
  Remove session in api tests (go-gitea#21984)
  Remove duplicate "Actions" label in mobile view (go-gitea#21974)
  Fix generate index failure possibility on postgres (go-gitea#21998)
  Use path not filepath in template filenames (go-gitea#21993)
  Update chroma to v2.4.0 (go-gitea#22000)
  Util type to parse ref name (go-gitea#21969)
  Skip initing LFS storage if disabled (go-gitea#21996)
  Fix parallel creating commit status bug with tests (go-gitea#21911)
  Skip initing disabled storages (go-gitea#21985)
  Fix leaving organization bug on user settings -> orgs (go-gitea#21983)
  Fix typos (go-gitea#21979)
  Normalize `AppURL` according to RFC 3986 (go-gitea#21950)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants