-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Swift package registry #22404
Add Swift package registry #22404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just finished the code review without a test. Trusted Approval.
r.Group("/{version}", func() { | ||
r.Get("/Package.swift", swift.CheckAcceptMediaType(swift.AcceptSwift), swift.DownloadManifest) | ||
r.Put("", reqPackageAccess(perm.AccessModeWrite), swift.CheckAcceptMediaType(swift.AcceptJSON), swift.UploadPackageFile) | ||
r.Get("", func(ctx *context.Context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this code block be moved into a swfit-related go file to keep the api.go
simple?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep it here because it's not "swift logic" but "router logic". The docker part at the end of the file does something similar.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #22404 +/- ##
=========================================
+ Coverage 0 47.18% +47.18%
=========================================
Files 0 1151 +1151
Lines 0 151938 +151938
=========================================
+ Hits 0 71697 +71697
- Misses 0 71775 +71775
- Partials 0 8466 +8466
... and 1142 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
🎺 🤖 |
This PR adds a Swift package registry.