Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename actions unit to repo.actions and add docs for it (#23733) #23881

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Apr 3, 2023

Backport #23733 by @wolfogre

I neglected that the NameKey of Unit is not only for translation, but also configuration. So it should be repo.actions to maintain consistency.

⚠️ BREAKING ⚠️

If users already use actions.actions in DISABLED_REPO_UNITS or DEFAULT_REPO_UNITS, it will be treated as an invalid unit key.

…3733)

I neglected that the `NameKey` of `Unit` is not only for translation,
but also configuration. So it should be `repo.actions` to maintain
consistency.

## ⚠️ BREAKING ⚠️

If users already use `actions.actions` in `DISABLED_REPO_UNITS` or
`DEFAULT_REPO_UNITS`, it will be treated as an invalid unit key.
@GiteaBot GiteaBot added pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/bug labels Apr 3, 2023
@GiteaBot GiteaBot added this to the 1.19.2 milestone Apr 3, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 3, 2023
@lunny lunny modified the milestones: 1.19.2, 1.19.1 Apr 3, 2023
@6543 6543 merged commit 1886bd6 into go-gitea:release/v1.19 Apr 3, 2023
@6543 6543 removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 3, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
@techknowlogick techknowlogick deleted the backport-23733-v1.19 branch September 9, 2023 05:31
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants