Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update redis library to support redis v7 #24114

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

techknowlogick
Copy link
Member

Fix #24113

@pat-s could you test this PR to confirm it works with redis v7 clusters?

@techknowlogick techknowlogick added this to the 1.20.0 milestone Apr 13, 2023
@techknowlogick techknowlogick requested a review from pat-s April 13, 2023 20:21
@pat-s
Copy link
Member

pat-s commented Apr 13, 2023

Dang I was a few seconds too slow in #24113 😅

Yes, I have a current dev environment in which I am trying to connect to a redis 7 cluster using Gitea dailies.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 13, 2023
@pat-s pat-s mentioned this pull request Apr 13, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 13, 2023
@pat-s
Copy link
Member

pat-s commented Apr 13, 2023

Built an image from this branch and can confirm that connectivity to a redis-cluster works now! 🎉

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 13, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 13, 2023
@techknowlogick techknowlogick merged commit 985f76d into go-gitea:main Apr 13, 2023
@techknowlogick techknowlogick deleted the redis-9 branch April 13, 2023 22:41
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 13, 2023
@lunny lunny added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Apr 14, 2023
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.19. @techknowlogick, please send one manually. 🍵

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 14, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 14, 2023
* upstream/main:
  Fix incorrect server error content in RunnersList (go-gitea#24118)
  [skip ci] Updated translations via Crowdin
  Improve git log for debugging (go-gitea#24095)
  Update redis library to support redis v7 (go-gitea#24114)
  Refactor cookie (go-gitea#24107)
  Fix admin team access mode value in team_unit table (go-gitea#24012)
  Add monospace toggle button to textarea (go-gitea#24034)
  Correct the access log format (go-gitea#24085)
  Changelog v1.19.1 (go-gitea#24079) (go-gitea#24092)
@delvh delvh added backport/done All backports for this PR have been created and removed backport/manual No power to the bots! Create your backport yourself! labels Apr 16, 2023
techknowlogick added a commit that referenced this pull request Apr 17, 2023
backports #24114

---------

Co-authored-by: techknowlogick <hello@techknowlogick.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for redis v7 (via go-redis upgrade)
5 participants