Remove the parallelizing when loading repo for dashboard #24705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wxiaoguang
force-pushed
the
fix-dash-repo-go
branch
from
a1d4b82 to
fc539ef
Compare
lunny
approved these changes
May 14, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
added
the
skip-changelog
| repoIDsToLatestCommitSHAs := make(map[int64]string) | ||
| wg := sync.WaitGroup{} | ||
| wg.Add(len(repos)) | ||
| // at most there are dozens of repos (limited by MaxResponseItems), so it's not a big problem at the moment |
There was a problem hiding this comment.
(which is limited by RepoPagingNum)
There was a problem hiding this comment.
Are you sure?
The PageSize comes from PageSize: convert.ToCorrectPageSize(ctx.FormInt("limit")),, and ToCorrectPageSize says:
else if size > setting.API.MaxResponseItems {
size = setting.API.MaxResponseItems
}
There was a problem hiding this comment.
I see, limit is RepoPagingNum but this condition overrides it
There was a problem hiding this comment.
Luckily it's checked, that's what I have double-checked.
Otherwise, attackers could to "limit=99999" to DoS the server.
yardenshoham
approved these changes
May 14, 2023
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
yardenshoham
suggested changes
May 14, 2023
GiteaBot
added
lgtm/blocked
yardenshoham
removed
the
reviewed/wait-merge
Co-authored-by: Yarden Shoham <git@yardenshoham.com>
yardenshoham
approved these changes
May 14, 2023
GiteaBot
added
lgtm/done
|
Sorry for that, I assumed map was safe |
lunny
added
the
reviewed/wait-merge
Co-authored-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 15, 2023
* upstream/main: (30 commits) Don't filter action runs based on state (go-gitea#24711) Add Go package registry (go-gitea#24687) Fix flash of unstyled content in action view page (go-gitea#24712) Clean up various avatar dimensions (go-gitea#24701) Remove the parallelizing when loading repo for dashboard (go-gitea#24705) Optimize actions list by removing an unnecessary `git` call (go-gitea#24710) Update cron-translations.yml (go-gitea#24708) Fix run list broken when trigger user deleted (go-gitea#24706) Remove Fomantic comment module (go-gitea#24703) Update to Alpine 3.18 (go-gitea#24700) fix minio storage iterator path (go-gitea#24691) Add status indicator on main home screen for each repo (go-gitea#24638) Add test for api team orgnization (go-gitea#24699) Improve button-ghost, remove tertiary button (go-gitea#24692) Add icon support for safari (go-gitea#24697) Improve avatar uploading / resizing / compressing, remove Fomantic card module (go-gitea#24653) Fix docs documenting invalid `@every` for `OLDER_THAN` cron settings (go-gitea#24695) Fix `organization` field being `null` in `GET /api/v1/teams/{id}` (go-gitea#24694) Use standard HTTP library to serve files (go-gitea#24693) Add `eslint-plugin-eslint-comments` (go-gitea#24690) ...
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #24638
IMO, parallelizing might run out server resources more quickly. Gitea shouldn't use a lot of go-routine in a web handler.
And add a comment about how many repositories there could be at most.