Replace deprecated elliptic.Marshal
#26800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puni9869
approved these changes
Aug 29, 2023
GiteaBot
added
the
lgtm/need 1
pull-request-size
bot
added
the
size/XS
silverwind
approved these changes
Aug 29, 2023
|
Interestingly the lint run in #26799 did succeed, so no deprecation was detected. Still good to merge this. |
puni9869
added
reviewed/wait-merge
|
Leave it open a bit more, I'm not 100% sure the change is correct. |
silverwind
removed
the
reviewed/wait-merge
|
Backport? |
GiteaBot
added
lgtm/done
|
Can't backport as it requires go 1.20 or higher. |
puni9869
added
lgtm/blocked
GiteaBot
removed
the
lgtm/blocked
delvh
approved these changes
Aug 29, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 30, 2023
* giteaofficial/main:
Use `Set[Type]` instead of `map[Type]bool/struct{}`. (go-gitea#26804)
Fix verifyCommits error when push a new branch (go-gitea#26664)
Fix Uint8Array comparisons and update vitest (go-gitea#26805)
Add various missing files-changed dependencies (go-gitea#26799)
Improve flex list item padding (go-gitea#26779)
Include the GITHUB_TOKEN/GITEA_TOKEN secret for fork pull requests (go-gitea#26759)
feat(API): add route and implementation for creating/updating repository secret (go-gitea#26766)
Replace deprecated `elliptic.Marshal` (go-gitea#26800)
Updating the js libraries to latest version. (go-gitea#26795)
Fix some slice append usages (go-gitea#26778)
Use Go 1.21 for golangci-lint (go-gitea#26786)
Fix notification circle (border-radius) (go-gitea#26794)
Fix context filter has no effect in dashboard (go-gitea#26695)
Add default label in branch select list (go-gitea#26697)
Remove redundant nil check in `WalkGitLog` (go-gitea#26773)
Remove fomantic `item` module (go-gitea#26775)
Update info regarding internet connection for build (go-gitea#26776)
Fix being unable to use a repo that prohibits accepting PRs as a PR source. (go-gitea#26785)
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #26786, the Go version for golangci-lint is bumped to 1.21. This causes the following error:
The change now uses func (*PublicKey) ECDH, which is added in Go 1.20.