Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clean up template locale usage (#27856) #27857

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Clean up template locale usage (#27856) #27857

merged 1 commit into from
Oct 31, 2023

Conversation

wxiaoguang
Copy link
Contributor

Backport #27856

The only conflict is ThemeName in 500.tmpl, it has been resolved manually by keeping using old {{.SignedUser.Theme}}{{else}}{{DefaultTheme}}

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 31, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Oct 31, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2023
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 31, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 31, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 31, 2023
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 31, 2023
@silverwind silverwind merged commit 6ac2ade into go-gitea:release/v1.21 Oct 31, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 31, 2023
@wxiaoguang wxiaoguang deleted the backport-locale branch November 1, 2023 00:48
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 30, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@lunny lunny lunny approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @lunny @denyskon @silverwind @GiteaBot