Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Show/hide filetree button on small displays #27881

Conversation

sebastian-sauer
Copy link
Contributor

@sebastian-sauer sebastian-sauer commented Nov 2, 2023

the gt-df's display:flex !important did override the display:none on small displays

image

image

the gt-df's display:flex !important did override the display:none on small displays
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 2, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2023
@sebastian-sauer sebastian-sauer requested a review from delvh November 2, 2023 20:55
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 2, 2023
@wxiaoguang
Copy link
Contributor

It seems that the gt-ac and many styles of the class diff-toggle-file-tree-button could be simply replaced by btn interact-fg

add hide-992 helper class to hide element at screens < 992px
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2023
@sebastian-sauer
Copy link
Contributor Author

I've now removed the not needed classes and replaced the css with the helper classes.

@sebastian-sauer
Copy link
Contributor Author

@wxiaoguang is there anything else I should change?

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2023
@wxiaoguang wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 17, 2023
@wxiaoguang wxiaoguang enabled auto-merge (squash) November 17, 2023 18:11
@wxiaoguang wxiaoguang merged commit e31c6cf into go-gitea:main Nov 17, 2023
@GiteaBot GiteaBot added this to the 1.22.0 milestone Nov 17, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 17, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 20, 2023
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Update JS and PY dependencies (go-gitea#28120)
  Decrease issue font size in project template (go-gitea#28054)
  Require clear descriptions both for feature and breaking PRs prior to the merge (go-gitea#28112)
  add skip ci functionality (go-gitea#28075)
  Fix project counter in organization/individual profile (go-gitea#28068)
  Fix Show/hide filetree button on small displays (go-gitea#27881)
  Change default size of attachments and repo files (go-gitea#28100)
  Fix Matrix and MSTeams nil dereference (go-gitea#28089)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
the gt-df's display:flex !important did override the display:none on small displays

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 15, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants