Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use "is-loading" to avoid duplicate form submit for code comment (#28143) #28147

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

GiteaBot
Copy link
Collaborator

Backport #28143 by @wxiaoguang

Compare by ignoring spaces: https://github.com/go-gitea/gitea/pull/28143/files?diff=split&w=1

When the form is going to be submitted, add the "is-loading" class to show an indicator and avoid user UI events.

When the request finishes (success / error), remove the "is-loading" class to make user can interact the UI.

…gitea#28143)

When the form is going to be submitted, add the "is-loading" class to
show an indicator and avoid user UI events.

When the request finishes (success / error), remove the "is-loading"
class to make user can interact the UI.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 21, 2023
@GiteaBot GiteaBot added this to the 1.21.1 milestone Nov 21, 2023
@GiteaBot GiteaBot requested review from delvh and lunny November 21, 2023 03:01
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 21, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 21, 2023
@lunny lunny merged commit ffab076 into go-gitea:release/v1.21 Nov 21, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 19, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants