Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Increase "version" when update the setting value to a same value as before #28243

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 27, 2023

Setting the same value should not trigger DuplicateKey error, and the "version" should be increased

Fix #28242

@wxiaoguang wxiaoguang added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Nov 27, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Nov 27, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 27, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 27, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 27, 2023
@jolheiser jolheiser enabled auto-merge (squash) November 27, 2023 16:50
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 27, 2023
@jolheiser jolheiser merged commit a6aed0f into go-gitea:main Nov 27, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 27, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 27, 2023
…efore (go-gitea#28243)

Setting the same value should not trigger DuplicateKey error, and the
"version" should be increased
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 27, 2023
@wxiaoguang wxiaoguang deleted the fix-config-setting-set branch November 27, 2023 17:58
wxiaoguang added a commit that referenced this pull request Nov 27, 2023
…efore (#28243) (#28244)

Backport #28243

Setting the same value should not trigger DuplicateKey error, and the
"version" should be increased

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 28, 2023
* upstream/main:
  Use full width for project boards (go-gitea#28225)
  Increase "version" when update the setting value to a same value as before (go-gitea#28243)
  Fix issue will be detected as pull request when checking `First-time contributor` (go-gitea#28237)
  Fix link to `Code` tab on wiki commits (go-gitea#28041)
  Fix links in docs (go-gitea#28234)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
…efore (go-gitea#28243)

Setting the same value should not trigger DuplicateKey error, and the
"version" should be increased
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
…efore (go-gitea#28243)

Setting the same value should not trigger DuplicateKey error, and the
"version" should be increased
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 25, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
4 participants