Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor SSH clone URL generation code #28421

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Refactor SSH clone URL generation code #28421

merged 3 commits into from
Dec 15, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 11, 2023 •
edited
Loading

Refactor the code and add tests, keep the old logic.

@wxiaoguang wxiaoguang added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Dec 11, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Dec 11, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2023
@wxiaoguang wxiaoguang mentioned this pull request Dec 11, 2023
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2023
@wxiaoguang wxiaoguang changed the title Improve SSH clone URL generation behavior Refactor SSH clone URL generation code Dec 11, 2023
@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed type/bug labels Dec 11, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 15, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 15, 2023
@lunny lunny enabled auto-merge (squash) December 15, 2023 05:44
@lunny lunny merged commit 4f04ab2 into go-gitea:main Dec 15, 2023
@GiteaBot GiteaBot mentioned this pull request Dec 15, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 15, 2023
@wxiaoguang @GiteaBot
Refactor SSH clone URL generation code (go-gitea#28421)
319928e 
Refactor the code and add tests, keep the old logic.
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Dec 15, 2023
wxiaoguang added a commit that referenced this pull request Dec 15, 2023
@GiteaBot @wxiaoguang
Refactor SSH clone URL generation code (#28421) (#28480)
6cbb6f3 
Backport #28421 by wxiaoguang

Refactor the code and add tests, keep the old logic.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 15, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
aa7a2a8 
* giteaofficial/main:
  Refactor SSH clone URL generation code (go-gitea#28421)
@wxiaoguang wxiaoguang deleted the fix-ssh-clone-url branch December 15, 2023 13:31
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@wxiaoguang @fuxiaohei
Refactor SSH clone URL generation code (go-gitea#28421)
a33ee9a 
Refactor the code and add tests, keep the old logic.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@wxiaoguang @silverwind
Refactor SSH clone URL generation code (go-gitea#28421)
549d431 
Refactor the code and add tests, keep the old logic.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 14, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@lunny lunny lunny approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @Zettat123 @GiteaBot