Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix possible nil pointer access #28428

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Fix possible nil pointer access #28428

merged 3 commits into from
Dec 12, 2023

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Dec 11, 2023

There could be a nil pointer exception if the file is not found because that specific error is suppressed but not handled.

@KN4CK3R KN4CK3R added type/bug topic/packages backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 labels Dec 11, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 12, 2023
@lunny lunny enabled auto-merge (squash) December 12, 2023 13:16
@lunny lunny merged commit ff5106d into go-gitea:main Dec 12, 2023
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 12, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 12, 2023
@KN4CK3R @GiteaBot
Fix possible nil pointer access (go-gitea#28428)
dff6bd7 
There could be a nil pointer exception if the file is not found because
that specific error is suppressed but not handled.
@GiteaBot GiteaBot mentioned this pull request Dec 12, 2023
Merged
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 12, 2023
@KN4CK3R KN4CK3R deleted the fix-package-internal-cleanup branch December 12, 2023 13:53
lunny pushed a commit that referenced this pull request Dec 12, 2023
@GiteaBot @KN4CK3R
Fix possible nil pointer access (#28428) (#28440)
97a0bf1 
Backport #28428 by @KN4CK3R

There could be a nil pointer exception if the file is not found because
that specific error is suppressed but not handled.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.21. @KN4CK3R, please send one manually. 🍵

go run ./contrib/backport 28428
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Dec 13, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 13, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b4a4443 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix possible nil pointer access (go-gitea#28428)
  Don't show unnecessary citation JS error on UI (go-gitea#28433)
  Do some missing checks (go-gitea#28423)
  Deprecate query string auth tokens (go-gitea#28390)
@lunny lunny added backport/done All backports for this PR have been created and removed backport/v1.20 This PR should be backported to Gitea 1.20 labels Dec 13, 2023
@lunny
Copy link
Member

lunny commented Dec 13, 2023

Since backport to v1.20 automatically failed, maybe it's OK to only backport to v1.21.

fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@KN4CK3R @fuxiaohei
Fix possible nil pointer access (go-gitea#28428)
c7575a3 
There could be a nil pointer exception if the file is not found because
that specific error is suppressed but not handled.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@KN4CK3R @silverwind
Fix possible nil pointer access (go-gitea#28428)
ae3d80e 
There could be a nil pointer exception if the file is not found because
that specific error is suppressed but not handled.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 12, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/packages type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@KN4CK3R @GiteaBot @lunny @delvh