Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add endpoint for not implemented Docker auth #28457

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add endpoint for not implemented Docker auth #28457

merged 1 commit into from
Dec 13, 2023

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Dec 13, 2023

Recently Docker started to use the optional POST /v2/token endpoint which should respond with a 404 Not Found status code instead of the current 405 Method Not Allowed.

Note: Not all token servers implement oauth2. If the request to the endpoint returns 404 using the HTTP POST method, refer to Token Documentation for using the HTTP GET method supported by all token servers.

@KN4CK3R KN4CK3R added type/enhancement An improvement of existing functionality topic/packages labels Dec 13, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 13, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 13, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Dec 13, 2023
@techknowlogick techknowlogick added the backport/v1.21 This PR should be backported to Gitea 1.21 label Dec 13, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 13, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 13, 2023
@techknowlogick techknowlogick merged commit 064f052 into go-gitea:main Dec 13, 2023
@GiteaBot GiteaBot added this to the 1.22.0 milestone Dec 13, 2023
@GiteaBot GiteaBot mentioned this pull request Dec 13, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 13, 2023
@KN4CK3R @GiteaBot
Add endpoint for not implemented Docker auth (go-gitea#28457)
23a56bd 
Recently Docker started to use the optional `POST /v2/token` endpoint
which should respond with a `404 Not Found` status code instead of the
current `405 Method Not Allowed`.

> Note: Not all token servers implement oauth2. If the request to the
endpoint returns 404 using the HTTP POST method, refer to Token
Documentation for using the HTTP GET method supported by all token
servers.
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 13, 2023
@KN4CK3R KN4CK3R deleted the fix-docker-token branch December 13, 2023 20:30
KN4CK3R added a commit that referenced this pull request Dec 13, 2023
@GiteaBot @KN4CK3R
Add endpoint for not implemented Docker auth (#28457) (#28462)
74ab798 
Backport #28457 by @KN4CK3R

Recently Docker started to use the optional `POST /v2/token` endpoint
which should respond with a `404 Not Found` status code instead of the
current `405 Method Not Allowed`.

> Note: Not all token servers implement oauth2. If the request to the
endpoint returns 404 using the HTTP POST method, refer to Token
Documentation for using the HTTP GET method supported by all token
servers.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 14, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
cb0c502 
* giteaofficial/main:
  Abstract hash function usage (go-gitea#28138)
  Add endpoint for not implemented Docker auth (go-gitea#28457)
  docs: Update group membership fields to match application. (go-gitea#28175)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@KN4CK3R @fuxiaohei
Add endpoint for not implemented Docker auth (go-gitea#28457)
269ff0d 
Recently Docker started to use the optional `POST /v2/token` endpoint
which should respond with a `404 Not Found` status code instead of the
current `405 Method Not Allowed`.

> Note: Not all token servers implement oauth2. If the request to the
endpoint returns 404 using the HTTP POST method, refer to Token
Documentation for using the HTTP GET method supported by all token
servers.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@KN4CK3R @silverwind
Add endpoint for not implemented Docker auth (go-gitea#28457)
a77d0db 
Recently Docker started to use the optional `POST /v2/token` endpoint
which should respond with a `404 Not Found` status code instead of the
current `405 Method Not Allowed`.

> Note: Not all token servers implement oauth2. If the request to the
endpoint returns 404 using the HTTP POST method, refer to Token
Documentation for using the HTTP GET method supported by all token
servers.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 12, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/packages type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@KN4CK3R @techknowlogick @delvh @GiteaBot