Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(api): support ignore password if login source type is LDAP for creating user API (#28491) #28525

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

GiteaBot
Copy link
Collaborator

Backport #28491 by @appleboy

  • Modify the Password field in CreateUserOption struct to remove the Required tag
  • Update the v1_json.tmpl template to include the email field and remove the password field

…creating user API (go-gitea#28491)

- Modify the `Password` field in `CreateUserOption` struct to remove the
`Required` tag
- Update the `v1_json.tmpl` template to include the `email` field and
remove the `password` field

---------

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them type/bug labels Dec 19, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 19, 2023
@GiteaBot GiteaBot added this to the 1.21.3 milestone Dec 19, 2023
@GiteaBot GiteaBot requested review from lunny and wolfogre December 19, 2023 02:32
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 19, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 19, 2023
@lunny lunny merged commit 411310d into go-gitea:release/v1.21 Dec 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants