Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor timeutil package #28623

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Refactor timeutil package #28623

merged 2 commits into from
Dec 28, 2023

Conversation

wxiaoguang
Copy link
Contributor

  1. make names more readable
  2. remove unused FormatLong/FormatShort
  3. use FormatDate instead of Format "2006-01-02"

@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 28, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Dec 28, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 28, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 28, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 28, 2023
@lunny lunny enabled auto-merge (squash) December 28, 2023 09:46
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 28, 2023
@lunny lunny merged commit e743570 into go-gitea:main Dec 28, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 28, 2023
@wxiaoguang wxiaoguang deleted the refactor-timeutil branch December 28, 2023 10:11
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 29, 2023
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  switch destination directory for apt signing keys (go-gitea#28639)
  Extend description for ARTIFACT_RETENTION_DAYS (go-gitea#28626)
  Refactor timeutil package (go-gitea#28623)
  Refactor some legacy code and remove unused code (go-gitea#28622)
  Remove unnecessary syncbranchToDB with tests (go-gitea#28624)
  Do not set `Accept` header twice (go-gitea#28598)
  [skip ci] Updated translations via Crowdin
  fix wrong link in user and organization profile when using relative url (go-gitea#28617)
  Add get actions runner registration token for API routes, repo, org, user and global level (go-gitea#27144)
  Fix session key conflict with database keyword (go-gitea#28613)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
1. make names more readable
2. remove unused FormatLong/FormatShort
3. use `FormatDate` instead of `Format "2006-01-02"`
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
1. make names more readable
2. remove unused FormatLong/FormatShort
3. use `FormatDate` instead of `Format "2006-01-02"`
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
- If the session doesn't exist, it shouldn't be expected that the
variable is non-nil. Define the session variable instead and insert that.
- Add unit tests to test the behavior of the database sessions code .
- Regression caused by dd30d9d.
- Resolves https://codeberg.org/forgejo/forgejo/issues/2042

(cherry picked from commit 90307ad2004a9a9ddda30af4038224fedf0e6ca3)
(cherry picked from commit 874ef1978d7db5e8ba1482d4c8190b914fa110b3)
(cherry picked from commit 27d5f035fc744d932d1e4c95c55d98479fccf368)
(cherry picked from commit 65dbc4303ba8afdef70c573aaf782b76aaf0bbad)

[GITEA] Fix session generation for database (squash) timeutil.Mock

because of e743570 * Refactor timeutil package (go-gitea#28623)

(cherry picked from commit acc6b51be2b6d676129f653a8949b2c06aa2ad94)
(cherry picked from commit 02b74317f2d8120a705599d6ae908634a1fa2b44)
(cherry picked from commit 63b9b624bd203b7b5eff7439dbc09eeb9bc52ade)
(cherry picked from commit 7752ff8baa525918e00193606048e3c2dd5a4999)
(cherry picked from commit c0af4d943854ce3a77eaa75c06b04394301f45c4)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants