Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Also match weakly validated ETags #28957

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Also match weakly validated ETags #28957

merged 5 commits into from
Jan 29, 2024

Conversation

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 27, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 27, 2024
modules/httpcache/httpcache.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 27, 2024
@cchangwen cchangwen requested a review from KN4CK3R January 28, 2024 06:51
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Jan 28, 2024
modules/httpcache/httpcache.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2024
@delvh
Copy link
Member

delvh commented Jan 28, 2024

Is that an enhancement or a bugfix?

@KN4CK3R
Copy link
Member

KN4CK3R commented Jan 28, 2024

I would say enhancement.

@delvh delvh added type/enhancement An improvement of existing functionality topic/lfs labels Jan 28, 2024
@delvh delvh changed the title ETag TrimPrefix W/ Also match weakly validated ETags Jan 28, 2024
Co-authored-by: delvh <dev.lh@web.de>
@lunny lunny enabled auto-merge (squash) January 29, 2024 16:00
@lunny lunny merged commit 28fe3db into go-gitea:main Jan 29, 2024
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Jan 29, 2024
@cchangwen cchangwen deleted the patch-1 branch January 30, 2024 01:16
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 1, 2024
* giteaofficial/main:
  Revert "Speed up loading the dashboard on mysql/mariadb (go-gitea#28546)" (go-gitea#29006)
  Update dorny/paths-filter action (go-gitea#29003)
  [skip ci] Updated translations via Crowdin
  Fix UI Spacing Errors in mirror settings (go-gitea#28990)
  Add htmx guidelines (go-gitea#28993)
  Some refactor for git http (go-gitea#28995)
  Fix an actions schedule bug (go-gitea#28942)
  Fix doc img path in profile readme (go-gitea#28994)
  Introduce htmx and use it to avoid full page load on `Subscribe` and `Follow` (go-gitea#28908)
  Fix joins in `db.Find(AndCount)` (go-gitea#28978)
  Update golang links to use https (go-gitea#28980)
  Fix google logo in security page (go-gitea#28982)
  Also match weakly validated ETags (go-gitea#28957)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/lfs type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants