Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Display friendly error message (#29105) #29363

Merged
merged 4 commits into from
Feb 24, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 24, 2024

Backport #29105

ctx.Error only displays the text but ctx.ServerError renders the usual error page.

`ctx.Error` only displays the text but `ctx.ServerError` renders the
usual error page.
@lunny lunny added the type/bug label Feb 24, 2024
@lunny lunny added this to the 1.21.7 milestone Feb 24, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 24, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 24, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2024
@lng2020
Copy link
Member

lng2020 commented Feb 24, 2024

unrelated ci failure. It's due to #29355 -> Flaky test: TestXSSWikiLastCommitInfo

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 24, 2024
@lunny lunny enabled auto-merge (squash) February 24, 2024 10:40
@lunny lunny merged commit a1c0b3a into go-gitea:release/v1.21 Feb 24, 2024
27 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 24, 2024
@lunny lunny deleted the lunny/fix-wrong-error-method branch February 27, 2024 12:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants