Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add missing database transaction for new issue #29490

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Add missing database transaction for new issue #29490

merged 4 commits into from
Mar 4, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 29, 2024 •
edited
Loading

When creating an issue, inserting issue, assign users and set project should be in the same transaction.

@lunny lunny added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Feb 29, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 29, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 29, 2024
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Feb 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2024
@lunny lunny enabled auto-merge (squash) March 4, 2024 10:43
@lunny lunny merged commit e917334 into go-gitea:main Mar 4, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 4, 2024
@GiteaBot
Copy link
Collaborator

GiteaBot commented Mar 4, 2024

I was unable to create a backport for 1.21. @lunny, please send one manually. 🍵

go run ./contrib/backport 29490
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 4, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 4, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
79032d9 
* giteaofficial/main:
  Document that all unmerged feature PRs will be moved to next milestone when the feature freeze time comes (go-gitea#29578)
  Make admin pages wider because of left sidebar added and some tables become too narrow (go-gitea#29581)
  Refactor star/watch button (go-gitea#29576)
  Remove unnecessary SanitizeHTML from code (go-gitea#29575)
  Add missing database transaction for new issue (go-gitea#29490)
  Fix incorrect package link method calls in templates (go-gitea#29580)
  Move some asymkey functions to service layer (go-gitea#28894)
  Add user blocking (go-gitea#29028)

# Conflicts:
#	templates/repo/issue/view_content/context_menu.tmpl
@lunny lunny deleted the lunny/new_issue_transaction branch March 5, 2024 08:05
lunny added a commit to lunny/gitea that referenced this pull request Mar 5, 2024
@lunny
Add missing database transaction for new issue (go-gitea#29490)
44b4e7f 
When creating an issue, inserting issue, assign users and set project
should be in the same transaction.
@lunny lunny mentioned this pull request Mar 5, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Mar 5, 2024
lunny added a commit that referenced this pull request Mar 5, 2024
@lunny
Add missing database transaction for new issue (#29490) (#29607)
5667ef9 
When creating an issue, inserting issue, assign users and set project
should be in the same transaction.

Backport #29490
@lunny lunny removed this from the 1.23.0 milestone Mar 8, 2024
@lunny lunny added this to the 1.22.0 milestone Mar 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @GiteaBot @KN4CK3R @wolfogre