Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add an trailing slash to dashboard links #29555

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Add an trailing slash to dashboard links #29555

merged 3 commits into from
Mar 4, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 3, 2024 •
edited
Loading

Fix #29533, and add some tests for "base/paginate.tmpl"

@wxiaoguang wxiaoguang added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Mar 3, 2024
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Mar 3, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 3, 2024
@wxiaoguang wxiaoguang mentioned this pull request Mar 3, 2024
Closed
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 3, 2024
@github-actions github-actions bot removed the modifies/templates This PR modifies the template files label Mar 3, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 3, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2024
@silverwind silverwind enabled auto-merge (squash) March 4, 2024 00:24
@silverwind silverwind merged commit 8553b46 into go-gitea:main Mar 4, 2024
26 checks passed
@GiteaBot
Copy link
Collaborator

GiteaBot commented Mar 4, 2024

I was unable to create a backport for 1.21. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 29555
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 4, 2024
@silverwind silverwind deleted the fix-page-link branch March 4, 2024 01:04
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Mar 4, 2024
@wxiaoguang
Add an trailing slash to dashboard links (go-gitea#29555)
c02b942
@wxiaoguang wxiaoguang mentioned this pull request Mar 4, 2024
Merged
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 4, 2024
@zjjhot
Merge remote-tracking branch 'upstream/main'
b9e4a44 
* upstream/main:
  Replace some `gt-` classes with `tw-` (go-gitea#29570)
  Enable/disable owner and repo projects independently (go-gitea#28805)
  Add an trailing slash to dashboard links (go-gitea#29555)
  Extend issue template yaml engine (go-gitea#29274)
  [skip ci] Updated licenses and gitignores
  Fix workflow trigger event IssueChangeXXX bug (go-gitea#29559)
  Fix 500 when pushing release to an empty repo (go-gitea#29554)
  Update js and py dependencies, bump python (go-gitea#29561)
  Filter Repositories by type (go-gitea#29231)
lunny pushed a commit that referenced this pull request Mar 4, 2024
@wxiaoguang
Add a trailing slash to dashboard links (#29555) (#29573)
4ef7e49 
Backport #29555
@lunny lunny added the backport/done All backports for this PR have been created label Mar 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
4 participants
@wxiaoguang @GiteaBot @lunny @silverwind