Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove jQuery AJAX from the issue branch reference selection #29722

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Remove jQuery AJAX from the issue branch reference selection #29722

merged 2 commits into from
Mar 12, 2024

Conversation

yardenshoham
Copy link
Member

  • Replaced a single jQuery AJAX instance with our fetch wrapper
  • Tested the issue branch reference selection and it works as before

Demo using fetch instead of jQuery AJAX

demo

@yardenshoham
Remove jQuery AJAX from the issue branch selection
4d900c3 
- Removed a single jQuery AJAX instance
- Tested the issue branch reference selection and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2024
@yardenshoham yardenshoham added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 11, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 11, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 11, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 12, 2024
@lunny lunny enabled auto-merge (squash) March 12, 2024 04:25
@lunny lunny merged commit 75a9f61 into go-gitea:main Mar 12, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 12, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 12, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 12, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
81d1696 
* giteaofficial/main:
  Some performance optimization on dashboard and issues page (go-gitea#29010)
  Remove jQuery AJAX from the issue branch reference selection (go-gitea#29722)
  Lazy load object format with command line and don't do it in OpenRepository (go-gitea#29712)
  remove repetitive words (go-gitea#29695)
  Sync branches first (go-gitea#29714)
  Add a warning for disallowed email domains (go-gitea#29658)
  Fix inconsistent rendering of block mathematical expressions (go-gitea#29677)
@yardenshoham yardenshoham deleted the repo-legacy-jquery-ajax branch March 12, 2024 09:53
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 13, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 10, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yardenshoham @silverwind @delvh @lunny @GiteaBot