Refactor AddParam to AddParamIfExist #29834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
|
After this refactoring, we can see the a lot of old code could be simplified & clarified: TO Because there are already clear variables "mode". As a refactoring PR, old code is left as-is. Leave more improvements to the future. |
lunny
approved these changes
Mar 16, 2024
GiteaBot
added
lgtm/need 1
yardenshoham
approved these changes
Mar 16, 2024
GiteaBot
added
lgtm/done
6543
pushed a commit
that referenced
this pull request
Mar 16, 2024
Follow #29834 Remove AddParamIfExist, use "AddParamString" instead, it should clearly know what is being added into the parameters.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 16, 2024
* giteaofficial/main: (28 commits) Forbid jQuery `.prop` and fix related issues (go-gitea#29832) Fix wrong test for TestPullView_CodeOwner (go-gitea#29838) Forbid HTML injection using jQuery (go-gitea#29843) Meilisearch double quote on "match" query (go-gitea#29740) Forbid variables containing jQuery collections not having the `$` prefix (go-gitea#29839) Remove AddParamIfExist(AddParam) (go-gitea#29841) Refactor markdown attention render (go-gitea#29833) Refactor code_indexer to use an SearchOptions struct for PerformSearch (go-gitea#29724) Refactor AddParam to AddParamIfExist (go-gitea#29834) Forbid jQuery AJAX (go-gitea#29818) Remove jQuery AJAX from the notifications (go-gitea#29817) Light theme color enhancements (go-gitea#29830) Better highlighting of archved labels (go-gitea#29749) Remove the `time-since` class (go-gitea#29826) Remove jQuery AJAX from the project page (go-gitea#29814) Upgrade `htmx` to v1.9.11 (go-gitea#29821) Dark theme color enhancements (go-gitea#29822) Remove jQuery AJAX from the comment edit box (go-gitea#29812) Tweak labeler (go-gitea#29809) Fix `for` attribute not pointing to the ID of the color picker (go-gitea#29813) ... # Conflicts: # routers/web/user/home.go
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Mar 17, 2024
When read the code: `pager.AddParam(ctx, "search", "search")`, the
question always comes: What is it doing? Where is the value from? Why
"search" / "search" ?
Now it is clear: `pager.AddParamIfExist("search", ctx.Data["search"])`
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Mar 17, 2024
Follow go-gitea#29834 Remove AddParamIfExist, use "AddParamString" instead, it should clearly know what is being added into the parameters.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When read the code:
pager.AddParam(ctx, "search", "search"), the question always comes: What is it doing? Where is the value from? Why "search" / "search" ?Now it is clear:
pager.AddParamIfExist("search", ctx.Data["search"])