Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix missing password length check when change password #3039

Merged
merged 2 commits into from
Dec 2, 2017
Merged

Fix missing password length check when change password #3039

merged 2 commits into from
Dec 2, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 30, 2017

will fix #3036

@lunny lunny added this to the 1.4.0 milestone Nov 30, 2017
@lafriks
Copy link
Member

lafriks commented Nov 30, 2017

Test would be nice for this otherwise LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 30, 2017
@lafriks
Copy link
Member

lafriks commented Nov 30, 2017

No need to add this to milestone as this will be in 1.3.1

@ethantkoenig
Copy link
Member

+1 for adding tests. It should be straightforward to add some unit tests for SettingsSecurityPost(..); see routers/repo/wiki_test.go for some examples to follow.

@lunny lunny force-pushed the lunny/fix_min_password_check branch from 164c6f6 to 17471c5 Compare December 2, 2017 08:27
@lunny
Copy link
Member Author

lunny commented Dec 2, 2017

@lafriks @ethantkoenig tests added.

@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2017
@lafriks lafriks merged commit b3d5ba6 into go-gitea:master Dec 2, 2017
@lunny lunny deleted the lunny/fix_min_password_check branch December 3, 2017 01:38
lunny added a commit to lunny/gitea that referenced this pull request Dec 3, 2017
@lunny
Fix missing password length check when change password (go-gitea#3039)
36ff419 
* fix missing password length check when change password

* add tests for change password
@lunny lunny mentioned this pull request Dec 3, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Dec 3, 2017
lunny added a commit that referenced this pull request Dec 3, 2017
@lunny
Fix missing password length check when change password (#3039) (#3071)
3d688bd 
* fix missing password length check when change password

* add tests for change password
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

MIN_PASSWORD_LENGTH ignored when changing the password in user settings
4 participants
@lunny @lafriks @ethantkoenig @tboerger