Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Split sanitizer functions and fine-tune some tests #31192

Merged
merged 4 commits into from
May 31, 2024
Merged

Split sanitizer functions and fine-tune some tests #31192

merged 4 commits into from
May 31, 2024

Conversation

wxiaoguang
Copy link
Contributor

  1. Split "sanitizer.go" into small files
  2. Remove unnecessary NewSanitizer and introduce GetDefaultSanitizer
  3. Fine-tune some tests. For example: merge TestSanitizeNonEscape into TestSanitizer: it could simply test what is expected, instead of using Contains

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 31, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 31, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 31, 2024
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 31, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 31, 2024
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 31, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 31, 2024
@lunny lunny enabled auto-merge (squash) May 31, 2024 12:57
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 31, 2024
@wxiaoguang wxiaoguang disabled auto-merge May 31, 2024 13:21
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 31, 2024 13:22
@wxiaoguang wxiaoguang merged commit a427595 into go-gitea:main May 31, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 31, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 31, 2024
@wxiaoguang @GiteaBot
Split sanitizer functions and fine-tune some tests (go-gitea#31192)
6484e60
@GiteaBot GiteaBot mentioned this pull request May 31, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 31, 2024
@wxiaoguang wxiaoguang deleted the refactor-policy branch May 31, 2024 13:28
wxiaoguang added a commit that referenced this pull request May 31, 2024
@GiteaBot @wxiaoguang
Split sanitizer functions and fine-tune some tests (#31192) (#31200)
b6280f4 
Backport #31192 by wxiaoguang

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 3, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d0022eb 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Fix overflow in issue card (go-gitea#31203)
  Fix agit checkout command line hint & fix ShowMergeInstructions checking (go-gitea#31219)
  Fix the possible migration failure on 286 with postgres 16 (go-gitea#31209)
  Only update poster in issue/comment list if it has been loaded (go-gitea#31216)
  Return an empty string when a repo has no avatar in the repo API (go-gitea#31187)
  Split sanitizer functions and fine-tune some tests (go-gitea#31192)
  Performance improvements for pull request list API (go-gitea#30490)
  Fix URL In Gitea Actions Badge Docs (go-gitea#31191)
@cfi-gb
Copy link

cfi-gb commented Aug 6, 2024 •
edited
Loading

CVE-2024-6886 seems to have been assigned for this (At least https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-6886 is referring to this PR)

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 29, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @cfi-gb @lunny @silverwind @GiteaBot