Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix adopt repository has empty object name in database #31333

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 12, 2024

Fix #31330
Fix #31311

A workaround to fix the old database is to update object_format_name to sha1 if it's empty or null.

@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Jun 12, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 12, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 12, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 12, 2024
@lunny lunny force-pushed the lunny/fix_object_name_empty branch from 56e9746 to f887ed0 Compare June 12, 2024 09:51
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 12, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 12, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 12, 2024
@lunny lunny merged commit 1968c22 into go-gitea:main Jun 12, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 12, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 12, 2024
Fix go-gitea#31330
Fix go-gitea#31311

A workaround to fix the old database is to update object_format_name to
`sha1` if it's empty or null.
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jun 12, 2024
@lunny lunny deleted the lunny/fix_object_name_empty branch June 12, 2024 10:22
silverwind pushed a commit that referenced this pull request Jun 12, 2024
Backport #31333 by @lunny

Fix #31330
Fix #31311

A workaround to fix the old database is to update object_format_name to
`sha1` if it's empty or null.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 13, 2024
* giteaofficial/main:
  Fixed incorrect localization `explorer.go` (go-gitea#31348)
  Improve detecting empty files (go-gitea#31332)
  Fix hash render end with colon (go-gitea#31319)
  Fix line number widths (go-gitea#31341)
  Fix navbar `+` menu flashing on page load (go-gitea#31281)
  Reduce memory usage for chunked artifact uploads to MinIO (go-gitea#31325)
  Fix dates displaying in a wrong manner when we're close to the end of the month (go-gitea#31331)
  Fix adopt repository has empty object name in database (go-gitea#31333)
  Optimize profile layout to enhance visual experience (go-gitea#31278)
@wxiaoguang
Copy link
Contributor

-> Add a simple test for AdoptRepository #31391

wxiaoguang added a commit that referenced this pull request Jun 17, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 10, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
4 participants