Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: database not update release when using git push --tags --force #32040

Merged
merged 9 commits into from
Sep 18, 2024

Conversation

ExplodingDragon
Copy link
Contributor

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 14, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 14, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Sep 14, 2024
@ExplodingDragon ExplodingDragon changed the title Fix: database not updated when using git push --tags --force Fix: database not updated when using git push --tags --force Sep 14, 2024
@ExplodingDragon ExplodingDragon changed the title Fix: database not updated when using git push --tags --force Fix: database not update release when using git push --tags --force Sep 14, 2024
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label Sep 14, 2024
@lunny lunny added the type/bug label Sep 14, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 14, 2024
Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 18, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 18, 2024
@lunny lunny enabled auto-merge (squash) September 18, 2024 16:36
@lunny lunny merged commit 269c630 into go-gitea:main Sep 18, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Sep 18, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Sep 18, 2024
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Sep 18, 2024
lunny pushed a commit that referenced this pull request Sep 18, 2024
@ExplodingDragon ExplodingDragon deleted the bugfix-git-force-tags branch September 19, 2024 00:49
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 19, 2024
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix: database not update release when using `git push --tags --force` (go-gitea#32040)
  Resolve duplicate local string key related to PR comments (go-gitea#32073)
  Refactor CSRF protector (go-gitea#32057)
@yp05327 yp05327 modified the milestones: 1.24.0, 1.22.3, 1.23.0 Sep 19, 2024
yonas pushed a commit to yonasBSD/forgejo that referenced this pull request Sep 22, 2024
Closes #4274

link: go-gitea/gitea#32040

### Release notes

- [ ] I do not want this change to show in the release notes.

<!--start release-notes-assistant-->

## Draft release notes
<!--URL:https://codeberg.org/forgejo/forgejo-->
- Bug fixes
  - [PR](https://codeberg.org/forgejo/forgejo/pulls/5319): <!--number 5319 --><!--line 0 --><!--description Rml4OiBkYXRhYmFzZSBub3QgdXBkYXRlZCB3aGVuIHVzaW5nIGBnaXQgcHVzaCAtLXRhZ3MgLS1mb3JjZWA=-->Fix: database not updated when using `git push --tags --force`<!--description-->
<!--end release-notes-assistant-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5319
Reviewed-by: Otto <otto@codeberg.org>
Co-authored-by: Exploding Dragon <explodingfkl@gmail.com>
Co-committed-by: Exploding Dragon <explodingfkl@gmail.com>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Oct 3, 2024
Closes #4274

link: go-gitea/gitea#32040

### Release notes

- [ ] I do not want this change to show in the release notes.

<!--start release-notes-assistant-->

## Draft release notes
<!--URL:https://codeberg.org/forgejo/forgejo-->
- Bug fixes
  - [PR](https://codeberg.org/forgejo/forgejo/pulls/5319): <!--number 5319 --><!--line 0 --><!--description Rml4OiBkYXRhYmFzZSBub3QgdXBkYXRlZCB3aGVuIHVzaW5nIGBnaXQgcHVzaCAtLXRhZ3MgLS1mb3JjZWA=-->Fix: database not updated when using `git push --tags --force`<!--description-->
<!--end release-notes-assistant-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5319
Reviewed-by: Otto <otto@codeberg.org>
Co-authored-by: Exploding Dragon <explodingfkl@gmail.com>
Co-committed-by: Exploding Dragon <explodingfkl@gmail.com>
(cherry picked from commit a6508f5)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 18, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants