Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixed race condition when deleting documents by repoId in ElasticSearch #32185

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Fixed race condition when deleting documents by repoId in ElasticSearch #32185

merged 2 commits into from
Oct 3, 2024

Conversation

bsofiato
Copy link
Contributor

@bsofiato bsofiato commented Oct 3, 2024

Resolves #32184

@bsofiato
Fixed race condition when deleting documents by repoId in ElasticSearch
b7162c3 
Signed-off-by: Bruno Sofiato <bruno.sofiato@gmail.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 3, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 3, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 3, 2024
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label Oct 3, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 3, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 3, 2024
@denyskon denyskon added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 3, 2024
@denyskon denyskon added this to the 1.23.0 milestone Oct 3, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) October 3, 2024 15:34
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2024
@techknowlogick techknowlogick merged commit d266d19 into go-gitea:main Oct 3, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 3, 2024
@bsofiato @GiteaBot
Fixed race condition when deleting documents by repoId in ElasticSear…
908e1d4 
…ch (go-gitea#32185)

Resolves go-gitea#32184

---------

Signed-off-by: Bruno Sofiato <bruno.sofiato@gmail.com>
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2024
@GiteaBot GiteaBot mentioned this pull request Oct 3, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Oct 3, 2024
lunny pushed a commit that referenced this pull request Oct 3, 2024
@GiteaBot @bsofiato
Fixed race condition when deleting documents by repoId in ElasticSear…
361221c 
…ch (#32185) (#32188)

Backport #32185 by @bsofiato

Resolves #32184

Signed-off-by: Bruno Sofiato <bruno.sofiato@gmail.com>
Co-authored-by: Bruno Sofiato <bruno.sofiato@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 8, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
0ebc915 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Allow filtering PRs by poster in the ListPullRequests API (go-gitea#32209)
  Fix bug when there are multiple triggers with workflow dispatch (go-gitea#32200)
  [skip ci] Updated licenses and gitignores
  [skip ci] Updated translations via Crowdin
  Upgrade htmx to 2.0.3 (go-gitea#32192)
  Enhance USER_DISABLED_FEATURES to allow disabling change username or full name (go-gitea#31959)
  [skip ci] Updated translations via Crowdin
  Add support for searching users by email (go-gitea#30908)
  Fix PR creation on forked repositories (go-gitea#31863)
  [skip ci] Updated translations via Crowdin
  Fixed race condition when deleting documents by repoId in ElasticSearch (go-gitea#32185)
  add {{TEST_MINIO_ENDPOINT}} for local testing "with/without" docker + fix pgsql testing doc (go-gitea#32105)
  [skip ci] Updated translations via Crowdin
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 1, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@lunny lunny lunny approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Race condition when running ES delete_by_query
5 participants
@bsofiato @lunny @techknowlogick @denyskon @GiteaBot