Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add null check for responseData.invalidTopics #32212

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

cloudchamb3r
Copy link
Contributor

Screenshot 2024-10-08 at 10 49 10 AM

responseData.invalidTopics can be null but it wasn't handled.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 8, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 8, 2024
@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Oct 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 8, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 8, 2024
@lunny lunny merged commit 2e12343 into go-gitea:main Oct 8, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Oct 8, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 8, 2024
<img width="553" alt="Screenshot 2024-10-08 at 10 49 10 AM"
src="https://github.com/user-attachments/assets/faeef64d-684a-4aba-b7fc-c7c6a0301abe">

`responseData.invalidTopics` can be null but it wasn't handled.
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 8, 2024
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Oct 8, 2024
lunny pushed a commit that referenced this pull request Oct 9, 2024
Backport #32212 by @cloudchamb3r

<img width="553" alt="Screenshot 2024-10-08 at 10 49 10 AM"
src="https://github.com/user-attachments/assets/faeef64d-684a-4aba-b7fc-c7c6a0301abe">

`responseData.invalidTopics` can be null but it wasn't handled.

Co-authored-by: cloudchamb3r <jizon0123@protonmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 10, 2024
* giteaofficial/main:
  Refactor CSRF token (go-gitea#32216)
  [skip ci] Updated translations via Crowdin
  Fix incorrect "Target branch does not exist" in PR title (go-gitea#32222)
  update git book link to v2 (go-gitea#32221)
  [skip ci] Updated translations via Crowdin
  Add null check for responseData.invalidTopics (go-gitea#32212)
  Fix bug when a token is given public only (go-gitea#32204)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 6, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants