improve performance of diffs #32393
Merged
improve performance of diffs #32393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
|
Here are quick before & after videos showcasing viewing the files in a large pull request: Before: After: |
lunny
reviewed
Oct 31, 2024
wxiaoguang
reviewed
Nov 1, 2024
wxiaoguang
reviewed
Nov 1, 2024
wxiaoguang
reviewed
Nov 1, 2024
wxiaoguang
reviewed
Nov 1, 2024
wxiaoguang
reviewed
Nov 1, 2024
wxiaoguang
reviewed
Nov 1, 2024
wxiaoguang
reviewed
Nov 1, 2024
pull-request-size
bot
added
size/M
wxiaoguang
reviewed
Nov 1, 2024
wxiaoguang
approved these changes
Nov 1, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Nov 1, 2024
GiteaBot
added
lgtm/done
This has two major changes that significantly reduce the amount of work done for large diffs: * Kill a running git process when reaching the maximum number of files in a diff, preventing it from processing the entire diff. * When loading a diff with the URL param `file-only=true`, skip loading stats. This speeds up loading both hidden files of a diff and sections of a diff when clicking the "Show More" button. A couple of minor things from profiling: * Reuse open git commits if possible to avoid querying the repo. * Reuse existing repo in `PrepareViewPullInfo` if head and base are the same.
bohde
force-pushed
the
rb/diff-performance-improvements
branch
from
2f443b2 to
69acf6a
Compare
|
We need this to correctly handle the errors: Fix git error handling #32401 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 6, 2024
* giteaofficial/main: (21 commits) Use 8 as default value for git lfs concurrency (go-gitea#32421) Fix milestone deadline and date related problems (go-gitea#32339) Only query team tables if repository is under org when getting assignees (go-gitea#32414) Refactor RepoRefByType (go-gitea#32413) Refactor template ctx and render utils (go-gitea#32422) Refactor DateUtils and merge TimeSince (go-gitea#32409) Refactor markup package (go-gitea#32399) Add some handy markdown editor features (go-gitea#32400) Make LFS http_client parallel within a batch. (go-gitea#32369) Refactor repo legacy (go-gitea#32404) Replace DateTime with proper functions (go-gitea#32402) Fix git error handling (go-gitea#32401) Fix created_unix for mirroring (go-gitea#32342) Replace DateTime with DateUtils (go-gitea#32383) improve performance of diffs (go-gitea#32393) Refactor tests to prevent from unnecessary preparations (go-gitea#32398) Add artifacts test fixture (go-gitea#30300) Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled (go-gitea#32365) Fix a number of typescript issues (go-gitea#32308) Update go dependencies (go-gitea#32389) ...
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two major changes that significantly reduce the amount of work done for large diffs:
file-only=true, skip loading stats. This speeds up loading both hidden files of a diff and sections of a diff when clicking the "Show More" button.A couple of minor things from profiling are also included:
PrepareViewPullInfoif head and base are the same.The performance impact is going to depend heavily on the individual diff and the hardware it runs on, but when testing locally on a diff changing 100k+ lines over hundreds of files, I'm seeing a roughly 75% reduction in time to load the result of "Show More"